Re: [PATCH v4 3/3] NFSD: Sign filehandles

[kernel test robot <lkp@intel.com>]

Hi Benjamin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on e3934bbd57c73b3835a77562ca47b5fbc6f34287]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Coddington/NFSD-Add-a-key-for-signing-filehandles/20260206-231407
base:   e3934bbd57c73b3835a77562ca47b5fbc6f34287
patch link:    https://lore.kernel.org/r/d34d4f79a7d4c6b77ad260f925cb51c34fd53ce5.1770390036.git.bcodding%40hammerspace.com
patch subject: [PATCH v4 3/3] NFSD: Sign filehandles
config: x86_64-randconfig-121-20260207 (https://download.01.org/0day-ci/archive/20260207/202602071819.UF8h2gl7-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260207/202602071819.UF8h2gl7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602071819.UF8h2gl7-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> fs/nfsd/nfsfh.c:168:14: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned long long [usertype] hash @@     got restricted __le64 [usertype] @@
   fs/nfsd/nfsfh.c:168:14: sparse:     expected unsigned long long [usertype] hash
   fs/nfsd/nfsfh.c:168:14: sparse:     got restricted __le64 [usertype]
   fs/nfsd/nfsfh.c:191:14: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned long long [usertype] hash @@     got restricted __le64 [usertype] @@
   fs/nfsd/nfsfh.c:191:14: sparse:     expected unsigned long long [usertype] hash
   fs/nfsd/nfsfh.c:191:14: sparse:     got restricted __le64 [usertype]

vim +168 fs/nfsd/nfsfh.c

   143	
   144	/*
   145	 * Append an 8-byte MAC to the filehandle hashed from the server's fh_key:
   146	 */
   147	static int fh_append_mac(struct svc_fh *fhp, struct net *net)
   148	{
   149		struct nfsd_net *nn = net_generic(net, nfsd_net_id);
   150		struct knfsd_fh *fh = &fhp->fh_handle;
   151		siphash_key_t *fh_key = nn->fh_key;
   152		u64 hash;
   153	
   154		if (!(fhp->fh_export->ex_flags & NFSEXP_SIGN_FH))
   155			return 0;
   156	
   157		if (!fh_key) {
   158			pr_warn_ratelimited("NFSD: unable to sign filehandles, fh_key not set.\n");
   159			return -EINVAL;
   160		}
   161	
   162		if (fh->fh_size + sizeof(hash) > fhp->fh_maxsize) {
   163			pr_warn_ratelimited("NFSD: unable to sign filehandles, fh_size %d would be greater"
   164				" than fh_maxsize %d.\n", (int)(fh->fh_size + sizeof(hash)), fhp->fh_maxsize);
   165			return -EINVAL;
   166		}
   167	
 > 168		hash = cpu_to_le64(siphash(&fh->fh_raw, fh->fh_size, fh_key));
   169		memcpy(&fh->fh_raw[fh->fh_size], &hash, sizeof(hash));
   170		fh->fh_size += sizeof(hash);
   171	
   172		return 0;
   173	}
   174	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki