Re: [PATCH 2/6] crypto: zynqmp-sha: Change algo type from shash to ahash

Herbert Xu
2026-03-14T04:46:03Z

On Tue, Mar 03, 2026 at 12:49:49PM +0530, Harsh Jain wrote:
>
> +struct zynqmp_sha_desc_ctx {
> + struct ahash_request fallback_req;

Please use HASH_FBREQ_ON_STACK instead of rolling your own fallback.

See drivers/crypto/aspeed for an example.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt