public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Andreas Larsson <andreas@gaisler.com>,
	"David S. Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Subject: Does the SPARC optimized crypto and CRC code actually work?
Date: Mon, 16 Mar 2026 13:42:11 -0700	[thread overview]
Message-ID: <20260316204211.GA2661@quark> (raw)

Hi,

The Linux kernel contains various SPARC crypto opcodes optimized
functions in lib/crypto/sparc/, lib/crc/sparc/, and arch/sparc/crypto/.

As the kernel's crypto and CRC code has been refactored over time, we've
been updating how the SPARC optimized code is integrated accordingly.
However, QEMU doesn't support the SPARC crypto opcodes, which means that
even though I (and maybe others) been running the tests on SPARC kernels
in QEMU, this doesn't actually execute the SPARC optimized code.

So I have to ask: is someone in the SPARC community actually testing
this code regularly?  That includes running all the KUnit tests for
crypto and CRC as well as the traditional crypto self-tests.

If not, then unless QEMU support is forthcoming I'd suggest we drop this
code to avoid issues on SPARC systems.  The generic code is much better
tested and we know that it works on any architecture, including SPARC.
Correctness is the first priority, especially for cryptography.

- Eric

             reply	other threads:[~2026-03-16 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 20:42 Eric Biggers [this message]
2026-03-17  2:48 ` Does the SPARC optimized crypto and CRC code actually work? Nathaniel Roach
2026-03-17  3:45   ` Eric Biggers
2026-03-17  7:16     ` John Paul Adrian Glaubitz
2026-03-17 14:06       ` Theodore Tso
2026-03-17 14:14         ` John Paul Adrian Glaubitz
2026-03-22 14:59           ` Eric Biggers
2026-03-23  5:58             ` John Paul Adrian Glaubitz
2026-03-23 10:36       ` Nathaniel Roach
2026-03-23 18:20         ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316204211.GA2661@quark \
    --to=ebiggers@kernel.org \
    --cc=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox