* [PATCH] crypto: crc32c - Remove another outdated comment
@ 2026-03-16 20:56 Eric Biggers
2026-03-17 11:10 ` Ard Biesheuvel
2026-03-17 16:30 ` Eric Biggers
0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2026-03-16 20:56 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-crypto, Ard Biesheuvel, Eric Biggers
This code just calls crc32c(), which has a number of different
implementations, not just the byte-at-a-time table-based one.
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
This patch is targeting crc-next
crypto/crc32c.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/crypto/crc32c.c b/crypto/crc32c.c
index 1eff54dde2f7..3754985ab948 100644
--- a/crypto/crc32c.c
+++ b/crypto/crc32c.c
@@ -47,15 +47,10 @@ struct chksum_ctx {
struct chksum_desc_ctx {
u32 crc;
};
-/*
- * Steps through buffer one byte at a time, calculates reflected
- * crc using table.
- */
-
static int chksum_init(struct shash_desc *desc)
{
struct chksum_ctx *mctx = crypto_shash_ctx(desc->tfm);
struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);
base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: crc32c - Remove another outdated comment
2026-03-16 20:56 [PATCH] crypto: crc32c - Remove another outdated comment Eric Biggers
@ 2026-03-17 11:10 ` Ard Biesheuvel
2026-03-17 16:30 ` Eric Biggers
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2026-03-17 11:10 UTC (permalink / raw)
To: Eric Biggers, linux-kernel; +Cc: linux-crypto
On Mon, 16 Mar 2026, at 21:56, Eric Biggers wrote:
> This code just calls crc32c(), which has a number of different
> implementations, not just the byte-at-a-time table-based one.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting crc-next
>
> crypto/crc32c.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> diff --git a/crypto/crc32c.c b/crypto/crc32c.c
> index 1eff54dde2f7..3754985ab948 100644
> --- a/crypto/crc32c.c
> +++ b/crypto/crc32c.c
> @@ -47,15 +47,10 @@ struct chksum_ctx {
>
> struct chksum_desc_ctx {
> u32 crc;
> };
>
> -/*
> - * Steps through buffer one byte at a time, calculates reflected
> - * crc using table.
> - */
> -
> static int chksum_init(struct shash_desc *desc)
> {
> struct chksum_ctx *mctx = crypto_shash_ctx(desc->tfm);
> struct chksum_desc_ctx *ctx = shash_desc_ctx(desc);
>
>
> base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
> --
> 2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: crc32c - Remove another outdated comment
2026-03-16 20:56 [PATCH] crypto: crc32c - Remove another outdated comment Eric Biggers
2026-03-17 11:10 ` Ard Biesheuvel
@ 2026-03-17 16:30 ` Eric Biggers
1 sibling, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2026-03-17 16:30 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-crypto, Ard Biesheuvel
On Mon, Mar 16, 2026 at 01:56:59PM -0700, Eric Biggers wrote:
> This code just calls crc32c(), which has a number of different
> implementations, not just the byte-at-a-time table-based one.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting crc-next
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next
- Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-17 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-16 20:56 [PATCH] crypto: crc32c - Remove another outdated comment Eric Biggers
2026-03-17 11:10 ` Ard Biesheuvel
2026-03-17 16:30 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox