public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: crc32c - Remove more outdated usage information
@ 2026-03-14 17:31 Eric Biggers
  2026-03-17 11:07 ` Ard Biesheuvel
  2026-03-17 16:30 ` Eric Biggers
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2026-03-14 17:31 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-crypto, Ard Biesheuvel, Geert Uytterhoeven, Eric Biggers

Remove information from the crypto/crc32c.c file comment that is no
longer applicable now that nearly all users of CRC-32C are simply using
the crc32c() library function instead.  This continues the cleanup from
commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---

This patch is targeting crc-next.

 crypto/crc32c.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/crypto/crc32c.c b/crypto/crc32c.c
index 1eff54dde2f74..c6c9c727b25b4 100644
--- a/crypto/crc32c.c
+++ b/crypto/crc32c.c
@@ -1,10 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * Cryptographic API.
- *
- * CRC32C chksum
+ * crypto_shash support for CRC-32C
  *
  *@Article{castagnoli-crc,
  * author =       { Guy Castagnoli and Stefan Braeuer and Martin Herrman},
  * title =        {{Optimization of Cyclic Redundancy-Check Codes with 24
  *                 and 32 Parity Bits}},
@@ -13,20 +11,10 @@
  * volume =       {41},
  * number =       {6},
  * pages =        {},
  * month =        {June},
  *}
- * Used by the iSCSI driver, possibly others, and derived from
- * the iscsi-crc.c module of the linux-iscsi driver at
- * http://linux-iscsi.sourceforge.net.
- *
- * Following the example of lib/crc32, this function is intended to be
- * flexible and useful for all users.  Modules that currently have their
- * own crc32c, but hopefully may be able to use this one are:
- *  net/sctp (please add all your doco to here if you change to
- *            use this one!)
- *  <endoflist>
  *
  * Copyright (c) 2004 Cisco Systems, Inc.
  * Copyright (c) 2008 Herbert Xu <herbert@gondor.apana.org.au>
  */
 

base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: crc32c - Remove more outdated usage information
  2026-03-14 17:31 [PATCH] crypto: crc32c - Remove more outdated usage information Eric Biggers
@ 2026-03-17 11:07 ` Ard Biesheuvel
  2026-03-17 16:30 ` Eric Biggers
  1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2026-03-17 11:07 UTC (permalink / raw)
  To: Eric Biggers, linux-kernel; +Cc: linux-crypto, Geert Uytterhoeven



On Sat, 14 Mar 2026, at 18:31, Eric Biggers wrote:
> Remove information from the crypto/crc32c.c file comment that is no
> longer applicable now that nearly all users of CRC-32C are simply using
> the crc32c() library function instead.  This continues the cleanup from
> commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting crc-next.
>
>  crypto/crc32c.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> diff --git a/crypto/crc32c.c b/crypto/crc32c.c
> index 1eff54dde2f74..c6c9c727b25b4 100644
> --- a/crypto/crc32c.c
> +++ b/crypto/crc32c.c
> @@ -1,10 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * Cryptographic API.
> - *
> - * CRC32C chksum
> + * crypto_shash support for CRC-32C
>   *
>   *@Article{castagnoli-crc,
>   * author =       { Guy Castagnoli and Stefan Braeuer and Martin Herrman},
>   * title =        {{Optimization of Cyclic Redundancy-Check Codes with 24
>   *                 and 32 Parity Bits}},
> @@ -13,20 +11,10 @@
>   * volume =       {41},
>   * number =       {6},
>   * pages =        {},
>   * month =        {June},
>   *}
> - * Used by the iSCSI driver, possibly others, and derived from
> - * the iscsi-crc.c module of the linux-iscsi driver at
> - * http://linux-iscsi.sourceforge.net.
> - *
> - * Following the example of lib/crc32, this function is intended to be
> - * flexible and useful for all users.  Modules that currently have their
> - * own crc32c, but hopefully may be able to use this one are:
> - *  net/sctp (please add all your doco to here if you change to
> - *            use this one!)
> - *  <endoflist>
>   *
>   * Copyright (c) 2004 Cisco Systems, Inc.
>   * Copyright (c) 2008 Herbert Xu <herbert@gondor.apana.org.au>
>   */
> 
>
> base-commit: c13cee2fc7f137dd25ed50c63eddcc578624f204
> -- 
> 2.53.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] crypto: crc32c - Remove more outdated usage information
  2026-03-14 17:31 [PATCH] crypto: crc32c - Remove more outdated usage information Eric Biggers
  2026-03-17 11:07 ` Ard Biesheuvel
@ 2026-03-17 16:30 ` Eric Biggers
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2026-03-17 16:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-crypto, Ard Biesheuvel, Geert Uytterhoeven

On Sat, Mar 14, 2026 at 10:31:30AM -0700, Eric Biggers wrote:
> Remove information from the crypto/crc32c.c file comment that is no
> longer applicable now that nearly all users of CRC-32C are simply using
> the crc32c() library function instead.  This continues the cleanup from
> commit 0ef6eb10f2e0 ("crypto: Clean up help text for CRYPTO_CRC32C").
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> 
> This patch is targeting crc-next.
> 
>  crypto/crc32c.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

- Eric

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-17 16:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-14 17:31 [PATCH] crypto: crc32c - Remove more outdated usage information Eric Biggers
2026-03-17 11:07 ` Ard Biesheuvel
2026-03-17 16:30 ` Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox