* [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by
@ 2026-03-17 20:18 Thorsten Blum
2026-03-17 23:35 ` Gustavo A. R. Silva
2026-03-27 10:06 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Thorsten Blum @ 2026-03-17 20:18 UTC (permalink / raw)
To: Haren Myneni, Madhavan Srinivasan, Michael Ellerman,
Nicholas Piggin, Christophe Leroy (CS GROUP), Herbert Xu,
David S. Miller, Kees Cook, Gustavo A. R. Silva
Cc: Thorsten Blum, linuxppc-dev, linux-crypto, linux-kernel,
linux-hardening
Add the __counted_by() compiler attribute to the flexible array member
'group' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/crypto/nx/nx-842.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842.h b/drivers/crypto/nx/nx-842.h
index f5e2c82ba876..a04e85e9f78e 100644
--- a/drivers/crypto/nx/nx-842.h
+++ b/drivers/crypto/nx/nx-842.h
@@ -164,7 +164,7 @@ struct nx842_crypto_header {
__be16 ignore; /* decompressed end bytes to ignore */
u8 groups; /* total groups in this header */
);
- struct nx842_crypto_header_group group[];
+ struct nx842_crypto_header_group group[] __counted_by(groups);
} __packed;
static_assert(offsetof(struct nx842_crypto_header, group) == sizeof(struct nx842_crypto_header_hdr),
"struct member likely outside of struct_group_tagged()");
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by
2026-03-17 20:18 [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by Thorsten Blum
@ 2026-03-17 23:35 ` Gustavo A. R. Silva
2026-03-27 10:06 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2026-03-17 23:35 UTC (permalink / raw)
To: Thorsten Blum, Haren Myneni, Madhavan Srinivasan,
Michael Ellerman, Nicholas Piggin, Christophe Leroy (CS GROUP),
Herbert Xu, David S. Miller, Kees Cook, Gustavo A. R. Silva
Cc: linuxppc-dev, linux-crypto, linux-kernel, linux-hardening
On 3/17/26 14:18, Thorsten Blum wrote:
> Add the __counted_by() compiler attribute to the flexible array member
> 'group' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
-Gustavo
> ---
> drivers/crypto/nx/nx-842.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/nx/nx-842.h b/drivers/crypto/nx/nx-842.h
> index f5e2c82ba876..a04e85e9f78e 100644
> --- a/drivers/crypto/nx/nx-842.h
> +++ b/drivers/crypto/nx/nx-842.h
> @@ -164,7 +164,7 @@ struct nx842_crypto_header {
> __be16 ignore; /* decompressed end bytes to ignore */
> u8 groups; /* total groups in this header */
> );
> - struct nx842_crypto_header_group group[];
> + struct nx842_crypto_header_group group[] __counted_by(groups);
> } __packed;
> static_assert(offsetof(struct nx842_crypto_header, group) == sizeof(struct nx842_crypto_header_hdr),
> "struct member likely outside of struct_group_tagged()");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by
2026-03-17 20:18 [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by Thorsten Blum
2026-03-17 23:35 ` Gustavo A. R. Silva
@ 2026-03-27 10:06 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2026-03-27 10:06 UTC (permalink / raw)
To: Thorsten Blum
Cc: Haren Myneni, Madhavan Srinivasan, Michael Ellerman,
Nicholas Piggin, Christophe Leroy (CS GROUP), David S. Miller,
Kees Cook, Gustavo A. R. Silva, linuxppc-dev, linux-crypto,
linux-kernel, linux-hardening
On Tue, Mar 17, 2026 at 09:18:06PM +0100, Thorsten Blum wrote:
> Add the __counted_by() compiler attribute to the flexible array member
> 'group' to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/crypto/nx/nx-842.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 20:18 [PATCH] crypto: nx - annotate struct nx842_crypto_header with __counted_by Thorsten Blum
2026-03-17 23:35 ` Gustavo A. R. Silva
2026-03-27 10:06 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox