From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8C7A34CFCF; Mon, 30 Mar 2026 04:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774843715; cv=none; b=Nxqskf0OvfX4X6CnUDc7artaL2lb8SLu0pDd5ZMltBP+CNClRg1j4yG4G0nlRo+SNsEZvVLfyQwCaOGqWVKfKTypox2mLBgqTwkmR1Cu11PLiVT7FTR+oANwV0cLRfrlz3uN/x1P4Y+Dm3P6LKIe5WhlWRSh3awYiuqU0gVXuSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774843715; c=relaxed/simple; bh=+A5NQMhCBBRKzoUSudLKLJZAfA7+8FwRJRitDmnyubY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=acUczmSJLmHsBQAP7KwT5UTCbi1bqGOWfVxgObxvehqVDFD+g7lfSV8nek9M3iLDJTbZ4wjG887WFTBbx/vHFtgEu8OAbhSp5qcD395CNWJ5rozSJCIkQc3L4qqG1EEkUP8Gz3Oh5DN7fg4BUboXL+ASBGVmcu50Y1/ZN2YBWzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rk5v/EL7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rk5v/EL7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFE31C2BCB0; Mon, 30 Mar 2026 04:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774843715; bh=+A5NQMhCBBRKzoUSudLKLJZAfA7+8FwRJRitDmnyubY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rk5v/EL75EZ+hbfqEshAQz2QQe+iuSZNg84JSHBgQeHC7MQpiAlomNcv0214mZuA/ gbjlTaVuay4FRB4MdNSX8Dc51tayHV0e0emc/xX42elGiN+vJjajX0Mj+DjRgCotku NJi0Cx4TsK5vFwnV0mTb3dWliU8/DvykqoMFl4Ne60JHqqLvWC6hKlA59DG+0Ub0mK i/RlQXksnWCqxo0T2LZaEiVWOLa6KPURQ9Z4xB+WBPWlEQnWDb+1w70onILoyinJz8 gZZx9gSRcK/J1hwQTRHyR8albh/f2o81y7CxFJD3rwa1khO6zG0Hxaks+qBoOStyxZ Du8I3EdOFGAig== Date: Sun, 29 Mar 2026 21:07:24 -0700 From: Eric Biggers To: Andrew Morton Cc: Christoph Hellwig , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , Theodore Ts'o , "Jason A. Donenfeld" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: cleanup the RAID5 XOR library v4 Message-ID: <20260330040724.GA647721@sol> References: <20260327061704.3707577-1-hch@lst.de> <20260329213119.GA2106@quark> <20260329155126.a01a5729b7d8376712182851@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329155126.a01a5729b7d8376712182851@linux-foundation.org> On Sun, Mar 29, 2026 at 03:51:26PM -0700, Andrew Morton wrote: > > > > Reviewed-by: Eric Biggers > > Great, thanks, added to all changelogs. > > > But yes, as Andrew mentioned there are two "xor: add a better public > > API" patches. They should be folded together. > > I folded them. > > I'm a bit wobbly about upstreaming all this for 7.1-rc1. It hits on a > lot of stuff and I don't think we've heard a lot from the affected > maintainers. > > otoh, we're unlikely to learn much from an additional nine weeks in > linux-next so at some point one has to forge ahead and rely on seven > weeks of -rc to address any remaining niggles. And I'm confident that > Christoph will support his work well. > > But still, hearing some reassuring words about this would be > appreciated ;) The architecture-optimized crypto and CRC code has been the same way. I've been working on it across architectures, and most of the arch maintainers don't pay much attention to it. I've seen engagement from a few of them, for example s390. But as a general rule it's a separate group of people working on this code. I think seeing the same for lib/raid/ is expected. So while the arch maintainers are always welcome to chime in, I don't think we need to wait for all of them, as then we'd be waiting forever. Re testing, I've been running the crypto, CRC, and now the XOR KUnit tests in QEMU for 8 architectures (arm, arm64, mips, powerpc, riscv, s390, sparc, and x86), and over 40 variants within those (e.g. varying CONFIG_64BIT, CONFIG_CPU_BIG_ENDIAN, and QEMU's "-cpu" flag). They are all passing, including the XOR test that Christoph added in this series. (So I guess feel free to add: Tested-by: Eric Biggers to all the patches in this series as well.) That still doesn't cover all the arch-optimized code, due to me missing various combinations or QEMU not supporting them. But it's something. I'm also hoping that with the move to standard KUnit tests, we'll get a larger group of people, including projects like KernelCI, that simply run *all* the kernel's KUnit tests on whatever platforms they care about. That approach is more scalable. - Eric