Re: [PATCH 0/5] crc64: Tweak intrinsics code and enable it for ARM

Eric Biggers
2026-04-02T23:41:40Z

On Thu, Apr 02, 2026 at 10:52:17AM +0200, Ard Biesheuvel wrote:
>
> On Wed, 1 Apr 2026, at 21:59, Eric Biggers wrote:
> > On Mon, Mar 30, 2026 at 04:46:31PM +0200, Ard Biesheuvel wrote:
> >> Apply some tweaks to the new arm64 crc64 NEON intrinsics code, and wire
> >> it up for the 32-bit ARM build. Note that true 32-bit ARM CPUs usually
> >> don't implement the prerequisite 64x64 PMULL instructions, but 32-bit
> >> kernels are commonly used on 64-bit capable hardware too, which do
> >> implement the 32-bit versions of the crypto instructions if they are
> >> implemented for the 64-bit ISA (as per the architecture).
> >>
> >> Cc: Demian Shulhan <demyansh@gmail.com>
> >> Cc: Eric Biggers <ebiggers@kernel.org>
> >>
> >> Ard Biesheuvel (5):
> >> lib/crc: arm64: Drop unnecessary chunking logic from crc64
> >> lib/crc: arm64: Use existing macros for kernel-mode FPU cflags
> >> ARM: Add a neon-intrinsics.h header like on arm64
> >> lib/crc: arm64: Simplify intrinsics implementation
> >> lib/crc: arm: Enable arm64's NEON intrinsics implementation of crc64
> >
> > I think patches 3 and 4 should be swapped, so it's cleanups first (which
> > make sense regardless of the 32-bit ARM support) and then the 32-bit ARM
> > support.
> >
>
> Ok.

I can also apply patches 1-2 and 4 now if you want. Let me know if I
should do that or if a new version is coming.

- Eric