From: Eric Biggers <ebiggers@kernel.org>
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [linus:master] [lib/crypto] e5046823f8: stress-ng.urandom.ops_per_sec 4.3% regression
Date: Wed, 15 Apr 2026 10:47:55 -0700 [thread overview]
Message-ID: <20260415174755.GB3142@quark> (raw)
In-Reply-To: <202604151657.8e26ef70-lkp@intel.com>
[+Cc Jason and Ted]
On Wed, Apr 15, 2026 at 04:45:48PM +0800, kernel test robot wrote:
>
>
> Hello,
>
> kernel test robot noticed a 4.3% regression of stress-ng.urandom.ops_per_sec on:
>
>
> commit: e5046823f8fa3677341b541a25af2fcb99a5b1e0 ("lib/crypto: chacha: Zeroize permuted_state before it leaves scope")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
This commit fixed the forward secrecy of the RNG, so it needed to go in.
For large RNG requests, we could get most of this performance back by
refactoring the chacha20_block() API to move the allocation of the
temporary state array into the caller.
We could also get much better performance than before by using the
architecture-optimized ChaCha20 code instead of the generic ChaCha20
code.
However, neither would be a simple change.
- Eric
next prev parent reply other threads:[~2026-04-15 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 8:45 [linus:master] [lib/crypto] e5046823f8: stress-ng.urandom.ops_per_sec 4.3% regression kernel test robot
2026-04-15 17:47 ` Eric Biggers [this message]
2026-04-16 0:45 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415174755.GB3142@quark \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox