From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>
Cc: kvm@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Tycho Andersen <tycho@kernel.org>
Subject: [PATCH v3 5/7] KVM: SEV: Don't advertise support for unusable VM types
Date: Thu, 16 Apr 2026 16:23:27 -0700 [thread overview]
Message-ID: <20260416232329.3408497-6-seanjc@google.com> (raw)
In-Reply-To: <20260416232329.3408497-1-seanjc@google.com>
Commit 0aa6b90ef9d7 ("KVM: SVM: Add support for allowing zero SEV ASIDs")
made it possible to make it impossible to use SEV VMs by not allocating
them any ASIDs.
Commit 6c7c620585c6 ("KVM: SEV: Add SEV-SNP CipherTextHiding support") did
the same thing for SEV-ES.
Do not export KVM_X86_SEV(_ES)_VM as supported types if in either of these
situations, so that userspace can use them to determine what is actually
supported by the current kernel configuration.
Also move the buildup to a local variable so it is easier to add additional
masking in future patches.
Link: https://lore.kernel.org/all/aZyLIWtffvEnmtYh@google.com/
Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Tycho Andersen (AMD) <tycho@kernel.org>
[sean: land code in sev_hardware_setup()]
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/svm/sev.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index dfeb660b8f5d..0971cf652b0b 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -3062,6 +3062,7 @@ void __init sev_hardware_setup(void)
bool sev_snp_supported = false;
bool sev_es_supported = false;
bool sev_supported = false;
+ u32 vm_types = 0;
if (!sev_enabled || !npt_enabled || !nrips)
goto out;
@@ -3195,24 +3196,26 @@ void __init sev_hardware_setup(void)
}
}
- if (sev_supported)
- kvm_caps.supported_vm_types |= BIT(KVM_X86_SEV_VM);
- if (sev_es_supported)
- kvm_caps.supported_vm_types |= BIT(KVM_X86_SEV_ES_VM);
+ if (sev_supported && min_sev_asid <= max_sev_asid)
+ vm_types |= BIT(KVM_X86_SEV_VM);
+ if (sev_es_supported && min_sev_es_asid <= max_sev_es_asid)
+ vm_types |= BIT(KVM_X86_SEV_ES_VM);
if (sev_snp_supported)
- kvm_caps.supported_vm_types |= BIT(KVM_X86_SNP_VM);
+ vm_types |= BIT(KVM_X86_SNP_VM);
+
+ kvm_caps.supported_vm_types |= vm_types;
if (boot_cpu_has(X86_FEATURE_SEV))
pr_info("SEV %s (ASIDs %u - %u)\n",
- sev_str_feature_state(sev_supported, min_sev_asid <= max_sev_asid),
+ sev_str_feature_state(sev_supported, vm_types & BIT(KVM_X86_SEV_VM)),
min_sev_asid, max_sev_asid);
if (boot_cpu_has(X86_FEATURE_SEV_ES))
pr_info("SEV-ES %s (ASIDs %u - %u)\n",
- sev_str_feature_state(sev_es_supported, min_sev_es_asid <= max_sev_es_asid),
+ sev_str_feature_state(sev_es_supported, vm_types & BIT(KVM_X86_SEV_ES_VM)),
min_sev_es_asid, max_sev_es_asid);
if (boot_cpu_has(X86_FEATURE_SEV_SNP))
pr_info("SEV-SNP %s (ASIDs %u - %u)\n",
- sev_str_feature_state(sev_snp_supported, true),
+ sev_str_feature_state(sev_snp_supported, vm_types & BIT(KVM_X86_SNP_VM)),
min_snp_asid, max_snp_asid);
sev_enabled = sev_supported;
--
2.54.0.rc1.513.gad8abe7a5a-goog
next prev parent reply other threads:[~2026-04-16 23:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 23:23 [PATCH v3 0/7] KVM: SEV: Don't advertise unusable VM types Sean Christopherson
2026-04-16 23:23 ` [PATCH v3 1/7] crypto/ccp: hoist kernel part of SNP_PLATFORM_STATUS Sean Christopherson
2026-04-17 13:48 ` Tom Lendacky
2026-04-16 23:23 ` [PATCH v3 2/7] crypto/ccp: export firmware supported vm types Sean Christopherson
2026-04-17 14:12 ` Tom Lendacky
2026-04-16 23:23 ` [PATCH v3 3/7] KVM: SEV: Set supported SEV+ VM types during sev_hardware_setup() Sean Christopherson
2026-04-17 14:24 ` Tom Lendacky
2026-04-16 23:23 ` [PATCH v3 4/7] KVM: SEV: Consolidate logic for printing state of SEV{,-ES,-SNP} enabling Sean Christopherson
2026-04-17 14:34 ` Tom Lendacky
2026-04-16 23:23 ` Sean Christopherson [this message]
2026-04-17 14:37 ` [PATCH v3 5/7] KVM: SEV: Don't advertise support for unusable VM types Tom Lendacky
2026-04-16 23:23 ` [PATCH v3 6/7] KVM: SEV: Don't advertise VM types that are disabled by firmware Sean Christopherson
2026-04-17 14:39 ` Tom Lendacky
2026-04-16 23:23 ` [PATCH v3 7/7] KVM: selftests: Teach sev_*_test about revoking VM types Sean Christopherson
2026-04-17 15:12 ` [PATCH v3 0/7] KVM: SEV: Don't advertise unusable " Tycho Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416232329.3408497-6-seanjc@google.com \
--to=seanjc@google.com \
--cc=ashish.kalra@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=tycho@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox