Re: [PATCH for-7.1-fixes 1/2] rhashtable: add no_sync_grow option

Herbert Xu
2026-04-17T00:43:48Z

On Thu, Apr 16, 2026 at 02:24:48PM -1000, Tejun Heo wrote:
> The sync grow path on insert calls get_random_u32() and kvmalloc(), both of

Where does the sync grow path call kvmalloc? I think it's supposed
to use GFP_ATOMIC kmalloc only. Only the normal growth path does
the kvmalloc for a linear hash table. The emergency path is supposed
to do page-by-page allocations to minimise failures.

As to get_random_u32, we can probably avoid doing it for emergency
growing and continue to reuse the existing seed.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt