From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
wangzhi@stu.xidian.edu.cn, byu@xidian.edu.cn,
w15303746062@163.com, vdronov@redhat.com,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Subject: [PATCH v2 0/2] crypto: qat - remove unused ioctl interface
Date: Sat, 9 May 2026 08:00:11 +0100 [thread overview]
Message-ID: <20260509070340.12201-1-giovanni.cabiddu@intel.com> (raw)
The QAT driver exposes a character device (qat_adf_ctl) with IOCTLs for
device configuration, start, stop, status query and enumeration. These
IOCTLs are not part of any public uAPI header and have no known in-tree
or out-of-tree users.
This ioctl interface increases the attack surface and is the subject of a
number of bug reports. Remove it entirely.
Patch 1 removes the character device, the IOCTL definitions, the related
data structures and headers. It strips adf_ctl_drv.c down to the
minimal module_init/module_exit hooks. This is marked for stable.
Patch 2 renames the now-minimal adf_ctl_drv.c to adf_module.c and
adjusts function names to match the new file name. This is not marked
for stable as it is a pure rename.
Changes since v1:
- Addressed comments from Sashiko: cleaned up leftover dead code
https://sashiko.dev/#/patchset/20260508091912.206913-1-giovanni.cabiddu%40intel.com
Giovanni Cabiddu (2):
crypto: qat - remove unused character device and IOCTLs
crypto: qat - rename adf_ctl_drv.c to adf_module.c
.../userspace-api/ioctl/ioctl-number.rst | 1 -
drivers/crypto/intel/qat/qat_common/Makefile | 2 +-
drivers/crypto/intel/qat/qat_common/adf_cfg.c | 10 -
drivers/crypto/intel/qat/qat_common/adf_cfg.h | 1 -
.../intel/qat/qat_common/adf_cfg_common.h | 29 --
.../intel/qat/qat_common/adf_cfg_user.h | 38 --
.../intel/qat/qat_common/adf_common_drv.h | 2 -
.../crypto/intel/qat/qat_common/adf_ctl_drv.c | 466 ------------------
.../crypto/intel/qat/qat_common/adf_dev_mgr.c | 32 --
.../crypto/intel/qat/qat_common/adf_module.c | 64 +++
10 files changed, 65 insertions(+), 580 deletions(-)
delete mode 100644 drivers/crypto/intel/qat/qat_common/adf_cfg_user.h
delete mode 100644 drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c
create mode 100644 drivers/crypto/intel/qat/qat_common/adf_module.c
base-commit: f7dd32c5179d7755de18e21d5674b08f9e5cb180
--
2.54.0
next reply other threads:[~2026-05-09 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 7:00 Giovanni Cabiddu [this message]
2026-05-09 7:00 ` [PATCH v2 1/2] crypto: qat - remove unused character device and IOCTLs Giovanni Cabiddu
2026-05-09 7:00 ` [PATCH v2 2/2] crypto: qat - rename adf_ctl_drv.c to adf_module.c Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260509070340.12201-1-giovanni.cabiddu@intel.com \
--to=giovanni.cabiddu@intel.com \
--cc=byu@xidian.edu.cn \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=vdronov@redhat.com \
--cc=w15303746062@163.com \
--cc=wangzhi@stu.xidian.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox