Re: [PATCH] crypto: tegra - Fix dma_free_coherent size error

[Vladislav Dronov <vdronov@redhat.com>]

On Tue, May 19, 2026 at 6:22 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
>         /* Allocate buffers required */
> -       rctx->inbuf.size = rctx->assoclen + rctx->authsize + rctx->cryptlen + 100;
> -       rctx->inbuf.buf = dma_alloc_coherent(ctx->se->dev, rctx->inbuf.size,
> +       bufsize = rctx->assoclen + rctx->authsize + rctx->cryptlen + 100;
> +       rctx->inbuf.size = bufsize;
> +       rctx->inbuf.buf = dma_alloc_coherent(ctx->se->dev, bufsize,
>                                              &rctx->inbuf.addr, GFP_KERNEL);
>         if (!rctx->inbuf.buf)
>                 goto out_finalize;

sashiko.dev makes a point here ( https://sashiko.dev/#/patchset/agvleqNqloWB6tpf%40gondor.apana.org.au )
that the code does not set ret to an error value, as done in the other similar places, see:

> -       rctx->outbuf.size = rctx->assoclen + rctx->authsize + rctx->cryptlen + 100;
> -       rctx->outbuf.buf = dma_alloc_coherent(ctx->se->dev, rctx->outbuf.size,
> +       rctx->outbuf.size = bufsize;
> +       rctx->outbuf.buf = dma_alloc_coherent(ctx->se->dev, bufsize,
>                                               &rctx->outbuf.addr, GFP_KERNEL);
>         if (!rctx->outbuf.buf) {
>                 ret = -ENOMEM;                    <<< HERE
                  goto out_free_inbuf;
          }

This looks valid to me, I'd suggest to add {}s and:

+                 ret = -ENOMEM;

to the patch indeed.

Best regards,
Vladislav Dronov