Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Goetz Goerisch <ggoerisch@gmail.com>
Cc: Paul Louvel <paul.louvel@bootlin.com>,
	herve.codina@bootlin.com, miquel.raynal@bootlin.com,
	stable@vger.kernel.org, thomas.petazzoni@bootlin.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-crypto@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] crypto: talitos - fix rename first/last to first_desc/last_desc
Date: Fri, 22 May 2026 07:12:56 +0200	[thread overview]
Message-ID: <2026052212-aged-amply-7bd8@gregkh> (raw)
In-Reply-To: <1464270648.58006.1779377119607@app.mailbox.org>

On Thu, May 21, 2026 at 05:25:18PM +0200, Goetz Goerisch wrote:
> Dear Paul,
> 
> Thank you for this review and feedback.
> 
> > > Instead of renaming req_ctx->last, commit 9826d1d6ed5f8 ("crypto: talitos - stop
> > > using crypto_ahash::init") should be applied. Ideally before commit
> > > 655ef638a2bc ("crypto: talitos - fix SEC1 32k ahash request limitation") to
> > > avoid any compilation breakage and ensure correctness of the code.
> > 
> > Small correction:
> > 
> > Ideally before commit 00463d5f864a ("crypto: talitos - fix SEC1 32k ahash
> > request limitation") to avoid any compilation breakage and ensure correctness of
> > the code.
> 
> I can confirm your recommendation. Appyling this commit before, fixes the problem. Please disregard my patch.
> 
> Greg could you please backport the mentioned commit to 6.6.y in the correct order for the next update?

Can you send a series of backported patches in the correct order for us
to apply, so we know to get them correct?  Trying to dig out from an
email like this is usually quite easy to get wrong :)

thanks,

greg k-h

  reply	other threads:[~2026-05-22  5:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <142603430.61540.1779296295550@app.mailbox.org>
2026-05-21 10:16 ` [PATCH] crypto: talitos - fix rename first/last to first_desc/last_desc Paul Louvel
2026-05-21 10:20   ` Paul Louvel
2026-05-21 15:25     ` Goetz Goerisch
2026-05-22  5:12       ` Greg Kroah-Hartman [this message]
2026-05-23 15:10         ` [PATCH 0/5] " Goetz Goerisch
2026-05-23 15:10           ` [PATCH 1/5] Revert "crypto: talitos - rename first/last to first_desc/last_desc" Goetz Goerisch
2026-05-23 15:10           ` [PATCH 2/5] Revert "crypto: talitos - fix SEC1 32k ahash request limitation" Goetz Goerisch
2026-05-23 15:10           ` [PATCH 3/5] crypto: talitos - stop using crypto_ahash::init Goetz Goerisch
2026-05-23 15:10           ` [PATCH 4/5] crypto: talitos - fix SEC1 32k ahash request limitation Goetz Goerisch
2026-05-23 15:10           ` [PATCH 5/5] crypto: talitos - rename first/last to first_desc/last_desc Goetz Goerisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052212-aged-amply-7bd8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ggoerisch@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=herve.codina@bootlin.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=paul.louvel@bootlin.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox