From: Akhil R <akhilrajeev@nvidia.com>
To: <vulab@iscas.ac.cn>
Cc: <akhilrajeev@nvidia.com>, <davem@davemloft.net>,
<herbert@gondor.apana.org.au>, <jonathanh@nvidia.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <stable@vger.kernel.org>,
<thierry.reding@kernel.org>
Subject: Re: [PATCH] crypto: tegra: fix refcount leak in tegra_se_host1x_submit()
Date: Fri, 5 Jun 2026 05:34:06 +0000 [thread overview]
Message-ID: <20260605053406.4142008-1-akhilrajeev@nvidia.com> (raw)
In-Reply-To: <20260604102706.3787771-1-vulab@iscas.ac.cn>
On Thu, 4 Jun 2026 10:27:06 +0000, Wentao Liang wrote:
> The timeout error path in tegra_se_host1x_submit() returns without
> calling host1x_job_put(), while all other paths (success, submit
> error, pin error) properly release the job reference through the
> job_put label. Since host1x_job_alloc() initializes the reference
> count and host1x_job_put() is required to drop it, omitting it on
> timeout causes a permanent refcount leak.
>
> Fix this by redirecting the timeout return to the existing job_put
> label, ensuring the job reference and any associated syncpt
> references are consistently released.
>
> Cc: stable@vger.kernel.org
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Thanks for the patch.
Reviewed-by: Akhil R <akhilrajeev@nvidia.com>
Best Regards,
Akhil
next prev parent reply other threads:[~2026-06-05 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 10:27 [PATCH] crypto: tegra: fix refcount leak in tegra_se_host1x_submit() Wentao Liang
2026-06-05 5:34 ` Akhil R [this message]
2026-06-11 8:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605053406.4142008-1-akhilrajeev@nvidia.com \
--to=akhilrajeev@nvidia.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jonathanh@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox