From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 850842517AC; Mon, 8 Jun 2026 18:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780941688; cv=none; b=oqopgnFg7PpbwRpPyt+c/kENrgNg3y6mLLWt15NhYIQ0vn87AmdWd5F8f0CDCiQOqvsOVgRtPTrS1n6obvjsr/7xIIqieRhv91kSq7pPKlVp0JnVD1cnZW5vKl4QEjCiM0eOjhmN7+aWpX9L3pBFPZQ2/2ZgViCLFpaXijhBhN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780941688; c=relaxed/simple; bh=+jT5XmHMFc85JUhWM7jAkGctPxS8ldMV+kNN3EDIm1o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DFZKWIAG73C3lbiSGg1dRB+YjPl+fJpmvG2DWo667rN/Bucjtiouxi1jbd50GVwml6rWTSQaPxgUsF/Q09T0Ix2t65NHxBAXZtByazeaElurzmcTa/VoK39l4vuCMiRnrs+xArXY/Bop4XM/zu5LzlVzfdfpkGTfRYDOAwwO6/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LLiCPT7U; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LLiCPT7U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C35D61F00893; Mon, 8 Jun 2026 18:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780941687; bh=n5i3xT3L2qpED+pWiLfyOeX9JWGnVgD43DrRzyZk8yM=; h=From:To:Cc:Subject:Date; b=LLiCPT7U9zav1a4LMWSpVaJK0BQ/jMefCWwKXWBF6vYaYgu7JM+ctC8ag3y/beCb2 WhNMaavniMXWONoBIKJBaU/Z66Mhe9q9pKanpamVqODMh579UhTsoyUzL/6n7AdWNr RPDPP80xrzDyoiCLcxNFSVG0JRuTZHUcTvLsC8cyc2x2NVJdfgPdleiuX7lY1FO6KE Pa4BGHvQD3+nt0XiWpKsAIkWejB0I1RBRMI+cKC7AXAwR7+N+L/Gnxnvg7Rduj1v/X R5nm7fG9Uqa7R/3JbsQVwfT+H06DGc9IUq7j5tNtglcUSEoQpCSqgBZL6DFY/grdtS LMsvtNzJ+ezcQ== From: Eric Biggers To: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Om Prakash Singh , Bjorn Andersson , Neil Armstrong , linux-arm-msm@vger.kernel.org, Olivia Mackall , Eric Biggers , Neeraj Soni , Dmitry Baryshkov , Konrad Dybcio Subject: [PATCH v2 0/4] qcom-rng fixes and cleanups Date: Mon, 8 Jun 2026 17:58:44 +0000 Message-ID: <20260608175848.2045229-1-ebiggers@kernel.org> X-Mailer: git-send-email 2.54.0.1064.gd145956f57-goog Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series fixes several bugs in qcom-rng, including failure to enable the clock before accessing the hardware, generating biased random numbers, and generating duplicate or non-random numbers due to missing locking. To fix the latter bug, it drops the support for the duplicative crypto_rng interface, which isn't used in practice, leaving just hwrng which is the one that actually matters. This series is targeting cryptodev/master Changed in v2: - Changed patch 3 to make the driver continue to be bound even when hwrng is unsupported. - Added blank line in patch 2 - Added Reviewed-by Eric Biggers (4): crypto: qcom-rng - Enable clock in hwrng case crypto: qcom-rng - Allow zero as a random number crypto: qcom-rng - Remove crypto_rng interface hwrng: qcom - Move qcom-rng.c into drivers/char/hw_random/ arch/arm/configs/multi_v7_defconfig | 2 +- arch/arm/configs/qcom_defconfig | 2 +- arch/arm64/configs/defconfig | 2 +- drivers/char/hw_random/Kconfig | 11 ++ drivers/char/hw_random/Makefile | 1 + drivers/{crypto => char/hw_random}/qcom-rng.c | 156 +++--------------- drivers/crypto/Kconfig | 12 -- drivers/crypto/Makefile | 1 - drivers/gpu/drm/ci/arm64.config | 2 +- 9 files changed, 41 insertions(+), 148 deletions(-) rename drivers/{crypto => char/hw_random}/qcom-rng.c (53%) base-commit: 79bbe453e5bfa6e1c6aa2e8329bfc8f152b81c9b -- 2.54.0.1064.gd145956f57-goog