From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72A1F35A393; Mon, 8 Jun 2026 18:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780941689; cv=none; b=BJNoE7bxkunKK+1eHAQUl7BVSq6Wi1uNrdjLx63wolJ9pDO5E/3NfJBLTA2zrYFGwoHfjd+9ylkeMca/OZpjPpsgdGjz2Tr9OL/UPMNLVnJ+go9Kq2vgzzwFseT93ApGbhp8iaD/eDjm55zshQIO4ASVS8sVqX/Bpzl5JOS6umw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780941689; c=relaxed/simple; bh=GlOqjbz3inGV9Jfgnw21p2hHZaG0EcbvAo0Cw52DWpo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RAuIA5iXuqfvrRsnMY3kfuOvGvH60iiq3dfRzkhqXWqqDrGWYEBF6A7cO8ynKDKB79jJMY6hb9JxkiU2Iwc7mHwr8Rz6/2Sz6u+0JvMDzmQVM7rsXP658FMLGTe3TqC3Ax4mScdGRWDO4mcXj9lx2wpMGI1VUdSIWzN4asaKT7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hmWHSAtx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hmWHSAtx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D49E01F00899; Mon, 8 Jun 2026 18:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780941688; bh=VrQ68f6nV/bENo0v3J/iZPKG/H3AUyXGEYgeAc35KaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hmWHSAtxNnI4cN5Ml9jOx+WQ6VsyS5M756UohBfiTsQuYbvUt2VArqdIyV+TqEaGx XGuMWeQ0k0P+3oAJ9ah8FGCzIacIoCUhqFn+pb8+X+yy576PMNf8hCFTGeI7a+HgCi JMNGkCVb75QoHQb2I18+R1iMSo66Db4u7yaEn5sxVXlvzg5Af58+Z9qn28Jl0iqbYj adQgT4jnMsi6v4/pyhhqPYMQyjU9MTrJmile2SN35sLG433AUlvqlMw72LK0YdIYiL jaotOP3u0SmJgwUqIwVHlscvMt+2+gyMhX95cPhFCK/94O5BdYnbbdNNaJjQCrL9d+ l1VlgHO1CU3yQ== From: Eric Biggers To: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Om Prakash Singh , Bjorn Andersson , Neil Armstrong , linux-arm-msm@vger.kernel.org, Olivia Mackall , Eric Biggers , Neeraj Soni , Dmitry Baryshkov , Konrad Dybcio , stable@vger.kernel.org Subject: [PATCH v2 2/4] crypto: qcom-rng - Allow zero as a random number Date: Mon, 8 Jun 2026 17:58:46 +0000 Message-ID: <20260608175848.2045229-3-ebiggers@kernel.org> X-Mailer: git-send-email 2.54.0.1064.gd145956f57-goog In-Reply-To: <20260608175848.2045229-1-ebiggers@kernel.org> References: <20260608175848.2045229-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Zero is a valid random number and needs to be allowed. Otherwise the output is distinguishable from random. Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Eric Biggers --- drivers/crypto/qcom-rng.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c index f31a7fe07ba7..7058bd98f9e9 100644 --- a/drivers/crypto/qcom-rng.c +++ b/drivers/crypto/qcom-rng.c @@ -63,12 +63,10 @@ static int qcom_rng_read(struct qcom_rng *rng, u8 *data, unsigned int max) 200, 10000); if (ret) return ret; val = readl_relaxed(rng->base + PRNG_DATA_OUT); - if (!val) - return -EINVAL; if ((max - currsize) >= WORD_SZ) { memcpy(data, &val, WORD_SZ); data += WORD_SZ; currsize += WORD_SZ; -- 2.54.0.1064.gd145956f57-goog