From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBCDB38399A; Fri, 26 Jun 2026 04:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782448768; cv=none; b=HRg5Z3NEaYkc1i5bQKhb1+wP8LeqUgTarsraNtQ6lFfDT2scEvBLsbk7vYWlEiL/b+DaDgiduBZlKKndEon5FFF7+4/hEXdEOkLxDOAgy8a+JlOi9CR6MgDbHHEFZ7e0r7UugL0MjCc7l0snXTLhoGKG2BH/iF8IOijjcqhg6nY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782448768; c=relaxed/simple; bh=RPItkOWasZqcyfOLtDz+/QpFuQkb3slxm+8bnisBhws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K8YXFRXtl2LoY9CDRGnwcC81Ofx6hKd6yZIBsKFoDZy7SkXjjzLOBWBc+nZHfTFU3H4ZGVBfEFyDEj48D2bOuKyW9MKT2zHCY9lTJk/ljZcu24qGBNLd0c3lRuYrikoZ/W1xtCdBg5s5ne/RVLKytjAiJ0blgS4EG42AAVgNhhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gZzDs4LY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gZzDs4LY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A6611F00A3E; Fri, 26 Jun 2026 04:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782448765; bh=XKHZjuqa6SA7Q+q9Rian771zvDreJMenlySa40ODDo4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gZzDs4LY1eQrVc4m3L3prP2YGRmr0ZDlgWf5RvT0ELnNdCSh6UFJ0vNT8Aip3r0Ps KcUEGZDvsjsYjD30dB5rZ10Ml0y30P4Ov5veDg+QkTGaXN0qBXMZgISNPLZD2LqLoH PfuDnsgatoprHVpvqvLHafIQnitGKb6aYbYSDwZUBs0nFA54f4wOlog6aIIbIQ20Xk fZmOd9ltXX0bAu9qbt/5Wdxckb91zl0Sq2GOPapRx38A0GUE3dVe4OCLRTxG3JH/QJ VVveOIT1nU0u218YJca17NApbALRkGWsglZA4JGcvABdb7cSlE5xfjI/LlyRnmAgYV CCRWLP1EKregA== From: Eric Biggers To: x86@kernel.org Cc: linux-um@lists.infradead.org, linux-raid@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Andrew Morton , Eric Biggers Subject: [PATCH 5/8] lib/crc: x86: Stop using cpu_has_xfeatures() Date: Thu, 25 Jun 2026 21:37:28 -0700 Message-ID: <20260626043731.319287-6-ebiggers@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260626043731.319287-1-ebiggers@kernel.org> References: <20260626043731.319287-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Checking both boot_cpu_has() and cpu_has_xfeatures() has never really been needed in practice, and it's never been universally done (e.g., lib/raid/ omits cpu_has_xfeatures()). Nevertheless, both x86 and UML now explicitly clear the AVX and AVX-512 flags if their xfeatures are missing, which should remove any remaining doubts. Thus, remove all the calls to cpu_has_xfeatures(). Signed-off-by: Eric Biggers --- lib/crc/x86/crc-pclmul-template.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/crc/x86/crc-pclmul-template.h b/lib/crc/x86/crc-pclmul-template.h index 02744831c6fa..893119bb7c07 100644 --- a/lib/crc/x86/crc-pclmul-template.h +++ b/lib/crc/x86/crc-pclmul-template.h @@ -25,20 +25,18 @@ crc_t prefix##_vpclmul_avx512(crc_t crc, const u8 *p, size_t len, \ DEFINE_STATIC_CALL(prefix##_pclmul, prefix##_pclmul_sse) static inline bool have_vpclmul(void) { return boot_cpu_has(X86_FEATURE_VPCLMULQDQ) && - boot_cpu_has(X86_FEATURE_AVX2) && - cpu_has_xfeatures(XFEATURE_MASK_YMM, NULL); + boot_cpu_has(X86_FEATURE_AVX2); } static inline bool have_avx512(void) { return boot_cpu_has(X86_FEATURE_AVX512BW) && boot_cpu_has(X86_FEATURE_AVX512VL) && - !boot_cpu_has(X86_FEATURE_PREFER_YMM) && - cpu_has_xfeatures(XFEATURE_MASK_AVX512, NULL); + !boot_cpu_has(X86_FEATURE_PREFER_YMM); } /* * Call a [V]PCLMULQDQ optimized CRC function if the data length is at least 16 * bytes, the CPU has PCLMULQDQ support, and the current context may use SIMD. -- 2.54.0