Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	x86@kernel.org, "Borislav Petkov" <bp@alien8.de>,
	"Carlos López" <clopez@suse.de>,
	"Alexey Kardashevskiy" <aik@amd.com>
Subject: Re: [PATCH 2/3] x86/sev: Remove obsolete virtual address check
Date: Wed, 22 Jul 2026 15:16:25 +0000	[thread overview]
Message-ID: <20260722151625.GB2794619@google.com> (raw)
In-Reply-To: <6ecb06b9-2543-4155-8ddf-4d58861a1cea@app.fastmail.com>

On Wed, Jul 22, 2026 at 12:01:43PM +0200, Ard Biesheuvel wrote:
> 
> 
> On Wed, 22 Jul 2026, at 04:53, Eric Biggers wrote:
> > Virtual addresses used with the AES-GCM library don't have to be in the
> > linear mapping.  Remove the virt_addr_valid() checks from
> > snp_send_guest_request(), which were a workaround left over from when
> > this code used crypto_aead, which required scatterlists.
> >
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > ---
> >  arch/x86/coco/sev/core.c | 9 ---------
> >  1 file changed, 9 deletions(-)
> >
> 
> Link: https://lore.kernel.org/all/20251010151036.42241-2-ardb+git@google.com/
> 

Thanks, I completely missed that.  Looks like the usual issue where
people were attached to workarounds even after the underlying problem
was fixed.  In the end, Alexey gave Reviewed-by and Tested-by on the
exact same diff, just it never got applied.  Alexey, would you mind if I
add those tags to this patch too?  Thanks!

- Eric

  reply	other threads:[~2026-07-22 15:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  2:53 [PATCH 0/3] Remove old AES-GCM library Eric Biggers
2026-07-22  2:53 ` [PATCH 1/3] x86/sev: Use new " Eric Biggers
2026-07-22  2:53 ` [PATCH 2/3] x86/sev: Remove obsolete virtual address check Eric Biggers
2026-07-22 10:01   ` Ard Biesheuvel
2026-07-22 15:16     ` Eric Biggers [this message]
2026-07-22  2:53 ` [PATCH 3/3] lib/crypto: aesgcm: Remove old AES-GCM library Eric Biggers
2026-07-22  9:59 ` [PATCH 0/3] " Ard Biesheuvel
2026-07-22 16:03 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722151625.GB2794619@google.com \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=aik@amd.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=clopez@suse.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox