From: Thorsten Blum <thorsten.blum@linux.dev>
To: Srujana Challa <schalla@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Thorsten Blum <thorsten.blum@linux.dev>,
Kees Cook <kees@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] crypto: octeontx - simplify get_{eng,ucode}_type_str helpers
Date: Thu, 23 Jul 2026 18:33:25 +0200 [thread overview]
Message-ID: <20260723163326.163043-2-thorsten.blum@linux.dev> (raw)
Remove the local variables, add default cases, and return the strings
directly.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
.../crypto/marvell/octeontx/otx_cptpf_ucode.c | 24 +++++++------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
index 417a48f41350..6b74b4737421 100644
--- a/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
+++ b/drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c
@@ -103,34 +103,26 @@ static void set_ucode_filename(struct otx_cpt_ucode *ucode,
static char *get_eng_type_str(int eng_type)
{
- char *str = "unknown";
-
switch (eng_type) {
case OTX_CPT_SE_TYPES:
- str = "SE";
- break;
-
+ return "SE";
case OTX_CPT_AE_TYPES:
- str = "AE";
- break;
+ return "AE";
+ default:
+ return "unknown";
}
- return str;
}
static char *get_ucode_type_str(int ucode_type)
{
- char *str = "unknown";
-
switch (ucode_type) {
case (1 << OTX_CPT_SE_TYPES):
- str = "SE";
- break;
-
+ return "SE";
case (1 << OTX_CPT_AE_TYPES):
- str = "AE";
- break;
+ return "AE";
+ default:
+ return "unknown";
}
- return str;
}
static int get_ucode_type(struct otx_cpt_ucode_hdr *ucode_hdr, int *ucode_type)
reply other threads:[~2026-07-23 16:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723163326.163043-2-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kees@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox