From: Guangshuo Li <lgs201920130244@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Tero Kristo <t-kristo@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Guangshuo Li <lgs201920130244@gmail.com>, stable@vger.kernel.org
Subject: [PATCH] crypto: omap-des: fix autosuspend cleanup during teardown
Date: Sat, 8 Aug 2026 16:42:12 +0800 [thread overview]
Message-ID: <20260808084212.2704516-1-lgs201920130244@gmail.com> (raw)
omap_des_probe() calls pm_runtime_use_autosuspend(), but neither the
probe failure path nor omap_des_remove() calls the matching
pm_runtime_dont_use_autosuspend() before disabling runtime PM.
If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
during teardown, this reference is not dropped and usage_count remains
unbalanced.
Add the missing pm_runtime_dont_use_autosuspend() calls to both the
probe failure and remove paths before disabling runtime PM.
This issue was found by manual code inspection.
Fixes: 418f2a8cf2eb ("crypto: omap-des - use runtime_pm autosuspend for clock handling")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/crypto/omap-des.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index dfaf831dd8ec..73425c06597a 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -1066,6 +1066,7 @@ static int omap_des_probe(struct platform_device *pdev)
err_irq:
cancel_work_sync(&dd->done_task);
err_get:
+ pm_runtime_dont_use_autosuspend(dev);
pm_runtime_disable(dev);
err_res:
dd = NULL;
@@ -1086,6 +1087,7 @@ static void omap_des_remove(struct platform_device *pdev)
cancel_work_sync(&dd->done_task);
omap_des_dma_cleanup(dd);
+ pm_runtime_dont_use_autosuspend(dd->dev);
pm_runtime_disable(dd->dev);
}
--
2.43.0
reply other threads:[~2026-08-08 8:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808084212.2704516-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox