From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8ADF346FA8 for ; Sat, 8 Aug 2026 09:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786179695; cv=none; b=V3wbVNcucWb5MyQfPkd04qgRHVkqkiuucpFexElE4cAI+vf4K3wcLEGGrtTGEayLc1kNRwpFiJJEY2tbCRdKjgIEtgHrLV7L6jFqG7kECivJc2UrLw0fG95H28tEabKZmNAJ/zSHdW2Y8P73EBZ+nKyqoN6kZ0vjWgrBiuBKfV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786179695; c=relaxed/simple; bh=k2o7RLdEaMQf8liSnLShdk2zw3dk1hd297iCbzakkMc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V0enV5p+v6o23QOgJ/oyRBQ5aEvByy9Ah0/LeACvaxmjzzGH8z8gBvXcapZ+McqT832sipE1FmneOHMMffjYh5SU082ZwH8k0tl4tEc9FvhB26OPjbdnCtgC+VSX5vvRtVUxdaCXH/4Tou+vKFNvJcu8BS4IlxxdD0YStMXfG1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aODdhckz; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aODdhckz" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2cf52d15d88so2642425ad.2 for ; Sat, 08 Aug 2026 02:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786179693; x=1786784493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Z8XEbNxmFITtGAeV3qoLd7HeCqmH9Ffgh8sG2RD/33I=; b=aODdhckzHMdGqUfPAE2aJFy2fKfRkVRAZlfgKQ1rZTC+vvDnORdhAc26Y8gylCV/Xh KZs8MkRWpCHl++ceU7kBkmAeScqg37XSlEB611yunwH0OLNcd+8jEHnfBkIjdZxqdq06 ins7RvizitqNGRFU8vXvMeOxPe0ZCpsx+ExWKlnVKCWjNSquHNFDgcu4Zt+230dBOA3M LIJ1U9reE03bXFIQKSgzDTBCQHSE0gxro9fYnUa4ck0TK6ofwPY7lgazcVHyXc7sPoqi aYZM6LqJ/eyQ8Adcmu6auSdC3I9Am3O/EYLIan8kKhkNdyHODJYodiI+9VVCf+OSGF1I LGvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786179693; x=1786784493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Z8XEbNxmFITtGAeV3qoLd7HeCqmH9Ffgh8sG2RD/33I=; b=Hrmy4r5giH34h4m6tomCoWBXnGVixV1aPWYkfr2YUvE7BSk/pak/ctH1K5V3h1vvWF xFeYBs4z5rVzrUQdHNI4jDHaU2mzig5Exb2CFRI6kKOanly5b+vZAqjtmOKwfRqlv7WD tVT8Ic0O0a6jeFskXTv8SalEu7USqP2oyk8PhK/P/1l4s8sovEU4HLlUdVToYhwuwZ0X shcUhg9cfOblJhUiSbpKBEJVQBswPTWFAiyLTAs5um+9R9hl3Q4tLSKmkOH2zY/dbubK ML6x4QoQvytpUegNyDTRNwEObQuY50KbDEczW7dzHgL9WwlPsu9bTZiZyEYLmpQx32c+ 9Udg== X-Forwarded-Encrypted: i=1; AHgh+RoOxnapqS76z+Awp0FlfadCC/aRINKEj08WNt3jRbwfn21Fmkx1ZF4ZRYW83TtQuiB7FTta0f7w2r5NLOM=@vger.kernel.org X-Gm-Message-State: AOJu0YwyZ0hQqpUUcFz5MSGTGKUyHB4Br4UNYZLtBm6k5xh8vlIDIIPY MKWzLzeA4b8bSz3fqCdpktmNj186Zk+MlrLbchgkcCrBLTLcUrgDBC0e X-Gm-Gg: AR+sD10j4JTd+kFwTTrFFVCknEaCnlFmQXG2ABqJloD4gOGAOJBOGHWpHbxv0qRe1Vd b/2INGT2gOVaErV6nly4fSGubTjmo6/jLenTHgHXpN9rie6amXQMZufhFWwvkzOwZTnJ3hrl42X 6NxLE13dZmi6CH6BYlq2btvMcVy/tEC/+IprCUyVwW62VrvRaGACWK0gp3D0W4a68txp+q6E4Hu //3Le5C33rJsWxO8BMpPx37CpzEa+TseWd+6mNu8LrWhe30Wey3azQKCjfN/q0RiCKiUXjKGnFE 8YVTVTUJ6B2TPvc3f4FO4JdpLZdoEIGfafOCHFlwL7ZfBsukCuN6Erv1/BAHiJ+cKKH+5oWqEgY /SDZlGUwtjKJrPhWr4CHS4W/FqVX4sEDmBDuyUMeAjcDmvNT4X8m8ntiXpjeDXPdUFpsSOVWYIX jYV3nQKKiWbYlN5bLqqbY7KHbgQeyFSG+PKSxczzrGzWKyPgfwzlgbsiqItuxKw7E9CqaA X-Received: by 2002:a17:90b:582e:b0:38e:485c:ebd3 with SMTP id 98e67ed59e1d1-392823d97aamr5991393a91.15.1786179692981; Sat, 08 Aug 2026 02:01:32 -0700 (PDT) Received: from lgs.. ([101.76.249.46]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925ff24b91sm5349083a91.9.2026.08.08.02.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 02:01:32 -0700 (PDT) From: Guangshuo Li To: Corentin Labbe , Herbert Xu , "David S. Miller" , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Arnd Bergmann , Guangshuo Li , Maxime Ripard , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] crypto: sun8i-ss: fix autosuspend cleanup during teardown Date: Sat, 8 Aug 2026 17:01:21 +0800 Message-ID: <20260808090121.2718855-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sun8i_ss_pm_init() calls pm_runtime_use_autosuspend(), but the autosuspend setting is not undone if pm_runtime_set_suspended() fails or when runtime PM is later torn down by sun8i_ss_pm_exit(). If the autosuspend delay is set to a negative value while autosuspend is enabled, the runtime PM core increments usage_count to prevent runtime suspend. Without calling pm_runtime_dont_use_autosuspend() during cleanup, this reference is not dropped and usage_count remains unbalanced. Undo the autosuspend setting when pm_runtime_set_suspended() fails and in sun8i_ss_pm_exit() before disabling runtime PM. This issue was found by manual code inspection. Fixes: f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c index 59c9bc45ec0f..775355ac9f9e 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c @@ -664,14 +664,18 @@ static int sun8i_ss_pm_init(struct sun8i_ss_dev *ss) pm_runtime_set_autosuspend_delay(ss->dev, 2000); err = pm_runtime_set_suspended(ss->dev); - if (err) + if (err) { + pm_runtime_dont_use_autosuspend(ss->dev); return err; + } + pm_runtime_enable(ss->dev); return err; } static void sun8i_ss_pm_exit(struct sun8i_ss_dev *ss) { + pm_runtime_dont_use_autosuspend(ss->dev); pm_runtime_disable(ss->dev); } -- 2.43.0