From: nitesh.venkatesh@intel.com
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
Nitesh Venkatesh <nitesh.venkatesh@intel.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Ahsan Atta <ahsan.atta@intel.com>
Subject: [PATCH 2/2] Documentation: qat: clarify KPT enable device-state requirement
Date: Mon, 31 Aug 2026 06:32:34 +0000 [thread overview]
Message-ID: <20260831063355.668528-3-nitesh.venkatesh@intel.com> (raw)
In-Reply-To: <20260831063355.668528-1-nitesh.venkatesh@intel.com>
From: Nitesh Venkatesh <nitesh.venkatesh@intel.com>
The ABI description for /sys/bus/pci/devices/<BDF>/qat_kpt/enable did
not mention that the device must be in the down state before the KPT
enable attribute can be written. This requirement is enforced by the
driver for both enabling and disabling KPT, but was not reflected in
the ABI documentation, leaving users to discover it via -EINVAL.
Update the description to note that the device must be in the down
state before changing the KPT state.
Signed-off-by: Nitesh Venkatesh <nitesh.venkatesh@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Ahsan Atta <ahsan.atta@intel.com>
---
Documentation/ABI/testing/sysfs-driver-qat_kpt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-driver-qat_kpt b/Documentation/ABI/testing/sysfs-driver-qat_kpt
index c6480ea1fa4f..80831ce3d2ca 100644
--- a/Documentation/ABI/testing/sysfs-driver-qat_kpt
+++ b/Documentation/ABI/testing/sysfs-driver-qat_kpt
@@ -14,7 +14,8 @@ Contact: qat-linux@intel.com
Description:
(RW) Enables or disables Key Protection Technology (KPT).
- Write 1 to enable KPT, or 0 to disable it.
+ Write 1 to enable KPT, or 0 to disable it. The device must be
+ in the down state before changing the KPT state.
Example usage::
--
2.52.0
prev parent reply other threads:[~2026-08-31 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 6:32 [PATCH 0/2] crypto: qat - fix KPT disable and clarify ABI nitesh.venkatesh
2026-08-31 6:32 ` [PATCH 1/2] crypto: qat - allow KPT disable when service is not asym nitesh.venkatesh
2026-08-31 6:32 ` nitesh.venkatesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831063355.668528-3-nitesh.venkatesh@intel.com \
--to=nitesh.venkatesh@intel.com \
--cc=ahsan.atta@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox