Linux cryptographic layer development
 help / color / mirror / Atom feed
From: T Pratham <t-pratham@ti.com>
To: T Pratham <t-pratham@ti.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>
Cc: Sebin Francis <sebin.francis@ti.com>,
	Manorit Chawdhry <m-chawdhry@ti.com>,
	Vishal Mahaveer <vishalm@ti.com>,
	Praneeth Bajjuri <praneeth@ti.com>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v4 08/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AES
Date: Thu, 10 Sep 2026 23:26:12 +0530	[thread overview]
Message-ID: <20260910175619.2122149-9-t-pratham@ti.com> (raw)
In-Reply-To: <20260910175619.2122149-1-t-pratham@ti.com>

sg_nents_for_len() returns -EINVAL if the supplied scatterlist is
shorter than the requested length.

Add explicit checks after each sg_nents_for_len() call in DTHEv2 AES
driver.

Fixes: 52f641bc63a46 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)")
Signed-off-by: T Pratham <t-pratham@ti.com>
---
 drivers/crypto/ti/dthev2-aes.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/crypto/ti/dthev2-aes.c b/drivers/crypto/ti/dthev2-aes.c
index aeccc235cb667..bc3591ec58a1c 100644
--- a/drivers/crypto/ti/dthev2-aes.c
+++ b/drivers/crypto/ti/dthev2-aes.c
@@ -354,6 +354,11 @@ static int dthe_aes_run(struct crypto_engine *engine, void *areq)
 	u32 aes_irqenable_val = readl_relaxed(aes_base_reg + DTHE_P_AES_IRQENABLE);
 	u32 aes_sysconfig_val = readl_relaxed(aes_base_reg + DTHE_P_AES_SYSCONFIG);
 
+	if (src_nents < 0 || dst_nents < 0) {
+		ret = -EINVAL;
+		goto aes_inval_nent_err;
+	}
+
 	aes_sysconfig_val |= DTHE_AES_SYSCONFIG_DMA_DATA_IN_OUT_EN;
 	writel_relaxed(aes_sysconfig_val, aes_base_reg + DTHE_P_AES_SYSCONFIG);
 
@@ -510,6 +515,7 @@ static int dthe_aes_run(struct crypto_engine *engine, void *areq)
 	if (ret == -ENOMEM)
 		ret = dthe_aes_do_fallback(req);
 
+aes_inval_nent_err:
 	local_bh_disable();
 	crypto_finalize_skcipher_request(dev_data->engine, req, ret);
 	local_bh_enable();
-- 
2.34.1


  parent reply	other threads:[~2026-09-10 17:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 17:56 [PATCH v4 00/15] Fix several issues in DTHEv2 driver T Pratham
2026-09-10 17:56 ` [PATCH v4 01/15] crypto: ti - Use list_first_entry_or_null() in dthe_get_dev() T Pratham
2026-09-10 17:56 ` [PATCH v4 02/15] crypto: ti - Fix spinlock inconsistency in DTHEv2 T Pratham
2026-09-10 17:56 ` [PATCH v4 03/15] crypto: ti - Fix potential memory corruption on highmem pages T Pratham
2026-09-10 17:56 ` [PATCH v4 04/15] crypto: ti - Fix use-after-free of dev_data on DTHEv2 driver removal T Pratham
2026-09-10 17:56 ` [PATCH v4 05/15] crypto: ti - Trim scatterlists to correct length in AES T Pratham
2026-09-10 17:56 ` [PATCH v4 06/15] crypto: ti - Align buffers to cacheline for DMA T Pratham
2026-09-10 17:56 ` [PATCH v4 07/15] crypto: ti - Separate padding buffer for src and dst T Pratham
2026-09-10 17:56 ` T Pratham [this message]
2026-09-10 17:56 ` [PATCH v4 09/15] crypto: ti - Validate sg_nents_for_len() return value in DTHEv2 AEAD T Pratham
2026-09-10 17:56 ` [PATCH v4 10/15] crypto: ti - Terminate DMA on all error paths in AES to clear descriptors T Pratham
2026-09-10 17:56 ` [PATCH v4 11/15] crypto: ti - Terminate DMA on all error paths in AEAD " T Pratham
2026-09-10 17:56 ` [PATCH v4 12/15] crypto: ti - Do AEAD software fallback on only ENOMEM T Pratham
2026-09-10 17:56 ` [PATCH v4 13/15] crypto: ti - Correct AEAD tag operations against dma cache invalidation T Pratham
2026-09-10 17:56 ` [PATCH v4 14/15] crypto: ti - Change lengths in AES to u64 to avoid potential overflows T Pratham
2026-09-10 17:56 ` [PATCH v4 15/15] crypto: ti - Change lengths in AEAD " T Pratham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910175619.2122149-9-t-pratham@ti.com \
    --to=t-pratham@ti.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=praneeth@ti.com \
    --cc=sebin.francis@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox