From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f42.google.com (mail-pz2-f42.google.com [74.125.228.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FD964BD35E for ; Wed, 16 Sep 2026 17:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789580572; cv=none; b=LkqAkkeMIoe7w1jvrWCDT4s7lbrHXvBbE4JEX0zD74I7VX18FjTucSjnUjQvlvqaTmkMvmGqe0KShg1p/nMQ1T7yb/WWvdcHqammX/R9tODb9NxRr5P8Y1URhuSDFqz/SnSZym4tY7487NX4uqRKKtQcOx4WmMuTnWmyDLXYCPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789580572; c=relaxed/simple; bh=HGNIvqMsniyjFCXq9xFvhYDTLciJsYL/vhVQM3VfuYg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YgwxRkPXPGXaVyKMq/bEOM1YDu8194JhgOtRt5nG2NeNUev/LV0YRO2/x4p18d299IPMhpbilyVzq3Q/krXSt0mSPlyEGAEeAfqsMTatDY+7A269oqy2iI/rzbwl+QrrdfLVmoV3QNEBC9aOWssYWyL0Py/vaFVVJoEd6lkjVkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lChBWklq; arc=none smtp.client-ip=74.125.228.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lChBWklq" Received: by mail-pz2-f42.google.com with SMTP id 41be03b00d2f7-cc4c3304784so1004922a12.3 for ; Wed, 16 Sep 2026 10:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789580557; x=1790185357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=SwgEhBXTngR3El+sf5PzSxyA5w4YUY1fd7mrK0Hv9aA=; b=lChBWklqhZnPDIkS75OXdgTL0BppdLUvkYjbFLlxGTn9qVv4Zy9AurKhEhblJDVI9O ypPAtT7kEEMldnLt59tT2x6flloPkI1wA0kvt//u1cIhqpCV9XIICakY8UF0SuL3Cz1l juYcQNGOTynGBC5NoRJVIDVGISAW9mqeKQhzyEgfy9Z55AKym8qvgm6Qx3RaXzMDPY+T cKoP8dppyLHgWNmArfqaG/nrkXg43l+VSuI3BnYKe6Zj0DqXsKxdu/8gf5cJzD+xVl6T M00skWPRBa/HKmo8Sd7XggiIpN5BuVQx73b8yVK4Ra16KT770Fxa4xZhThdPgsFnUUb6 k8Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789580557; x=1790185357; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SwgEhBXTngR3El+sf5PzSxyA5w4YUY1fd7mrK0Hv9aA=; b=wiDVxVIGHCNqBDL6b8Pc97rAxiKV4jArqRRz/Ke10V9ECQanXgFHtK6P0W7ZR2M2PL sLxfhOCUcOfySFnJc0R6xdsSSLT6tmDVsdKavKzmf7SDl4nBEw73Xsy+o9C2YpqETsHv Pv7BciV/ukr5EVpBoXX4St7H/RpuJnmrgjYGkNjCZBH6FlXPBKHmeVeUYEkcd8XI0VCZ dkG/cE6bQUzAdginqc0p5MaUAkqNAVbfcpW1AF6hquW/h1IJbHIdtLKfHlm7JDgo1Sz8 I+DFl0fswHL3IXA9qAW5IM4iN71CAitdHVkj+eIII3X5dOqvOC+eYrX9Fi8NlEk1+v07 lwpw== X-Gm-Message-State: AFuF++mq2l51+mvg86YQ++rWu1jjXGHxruimUSPBtFZsQSip8aGgQaFv RGv8h0aU81mWCvcBpuD5W2n9ig8Ix7betrZ8FfY/j8wfgyyluSb41vOR X-Gm-Gg: AYBFou3bR8LQM1l3AfhLEkZ9kjXR4x+Q/no2sW60YWrg+2oPuAhroDiqsWfkTXlG3xx VcnqkP2YYyL9sp9gsONpynbJX66hLIZWNyiWi5vCWlexMdRnAL+D2WWq0ZMl5ga+WQuNQGTnI6q AEQ1C+XZkEb4EjOjf8suwYi9FsSZHkQzn35wktaJBhteNOeMMBzMSb+Th6zKI7SCIKQpRllr9bz NOOwCTRWCok61DPalxe2lHAusLAxbmN536FWYZAWNAp1c3yFlMVL0CAxqCBAp6TEkpKWoohQV2C UOLwW9G1P7FRr7OuK8bRF1qr4c/inr4qT7oBkbN6t7ZamBF4zdYjf1eLqi6X+EmCM+WMMsvA5LV bgRfZalxOk5of4pw6UQAX1yYhfTm6dT9ZrNrN3rIUhG8DknHGcaUTfVm8lcoYrGfa/JLxckcA4T 4Pt0o4Io6nrXZcTXu/jAn2v6gzqBcR6T/oj1Ah2mRRKaW/6l/O/0RJsUrV7+8CuacnbmUMR0rIR re98YQDVaIjeJjDyQ== X-Received: by 2002:a17:90b:582c:b0:39d:f18c:1ad1 with SMTP id 98e67ed59e1d1-39e1e2501e6mr10461602a91.3.1789580557234; Wed, 16 Sep 2026 10:42:37 -0700 (PDT) Received: from kernel ([45.251.35.123]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14395d4cbc9sm7286360c88.11.2026.09.16.10.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2026 10:42:36 -0700 (PDT) From: Mohamad Raizudeen To: herbert@gondor.apana.org.au, clabbe@baylibre.com, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, jkoolstra@xs4all.nl, lkp@intel.com, Mohamad Raizudeen Subject: [PATCH v4] crypto/amlogic: Use devm APIs for clock management Date: Wed, 16 Sep 2026 23:12:27 +0530 Message-ID: <20260916174227.5581-1-raizudeen.kerneldev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver currently gets the core clock and manually enables it using clk_prepare_enable(). This requires matching calls to clk_disable_unprepare() in the error paths and remove function. Switch to devm_clk_get_enabled() instead. This lets the kernel handle enabling and disabling the clock automatically, which allow us to drop the manual cleanup code and keeps the probe function simple. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202608310329.QgxCCMs1-lkp@intel.com/ Signed-off-by: Mohamad Raizudeen --- Changes in v4: - Fix typo in meson_allocate_chanlist() function name. - Add error_chanlist label to properly free chanlist if IRQ requests fail, preventing a memory leak. Link to v3: https://lore.kernel.org/all/20260916154941.7254-1-raizudeen.kerneldev@gmail.com/T/ Link to v2: https://lore.kernel.org/all/20260901024302.5407-1-raizudeen.kerneldev@gmail.com/T/ Link to separate IRQ fix patch [1]: https://lore.kernel.org/all/20260908160120.4805-1-raizudeen.kerneldev@gmail.com/T/ drivers/crypto/amlogic/amlogic-gxl-core.c | 31 +++++++++-------------- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 169c6eeb51e5..f292bb25674f 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -243,34 +243,30 @@ static int meson_crypto_probe(struct platform_device *pdev) if (IS_ERR(mc->base)) return PTR_ERR(mc->base); - mc->busclk = devm_clk_get(&pdev->dev, "blkmv"); + mc->busclk = devm_clk_get_enabled(&pdev->dev, "blkmv"); if (IS_ERR(mc->busclk)) { err = PTR_ERR(mc->busclk); - dev_err(&pdev->dev, "Cannot get core clock err=%d\n", err); + dev_err(&pdev->dev, "Cannot get/enable core clock err=%d\n", err); return err; } + err = meson_allocate_chanlist(mc); + if (err) + return err; + for (i = 0; i < MAXFLOW; i++) { mc->irqs[i] = platform_get_irq(pdev, i); - if (mc->irqs[i] < 0) - return mc->irqs[i]; + if (mc->irqs[i] < 0) { + err = mc->irqs[i]; + goto error_chanlist; + } err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0, "gxl-crypto", mc); if (err < 0) - return err; - } - - err = clk_prepare_enable(mc->busclk); - if (err != 0) { - dev_err(&pdev->dev, "Cannot prepare_enable busclk\n"); - return err; + goto error_chanlist; } - err = meson_allocate_chanlist(mc); - if (err) - goto error_flow; - err = meson_register_algs(mc); if (err) goto error_alg; @@ -289,9 +285,8 @@ static int meson_crypto_probe(struct platform_device *pdev) return 0; error_alg: meson_unregister_algs(mc); +error_chanlist: meson_free_chanlist(mc, MAXFLOW - 1); -error_flow: - clk_disable_unprepare(mc->busclk); return err; } @@ -306,8 +301,6 @@ static void meson_crypto_remove(struct platform_device *pdev) meson_unregister_algs(mc); meson_free_chanlist(mc, MAXFLOW - 1); - - clk_disable_unprepare(mc->busclk); } static const struct of_device_id meson_crypto_of_match_table[] = { -- 2.53.0