Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	"Martin K . Petersen" <mkp@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Disseldorp <ddiss@suse.de>, Lee Duncan <lduncan@suse.com>,
	Alexandru Hossu <hossu.alexandru@gmail.com>
Subject: Re: [PATCH] scsi: target: iscsi: Use crypto library API
Date: Wed, 14 Oct 2026 18:48:55 +0200	[thread overview]
Message-ID: <20261014164855.GB327771@quark> (raw)
In-Reply-To: <20261001044857.169487-1-ebiggers@kernel.org>

On Wed, Sep 30, 2026 at 09:48:57PM -0700, Eric Biggers wrote:
> Make iscsi_target_auth.c call into the crypto library directly instead
> of going through crypto_shash.  This is simpler and much more efficient,
> as it avoids overhead of the crypto_shash layer.  The hash computation
> itself also no longer has error codes that need to be checked.
> 
> For simplicity, still do a memory allocation per operation to buffer the
> data (which is typically less than 50 bytes here) so that the one-shot
> digest functions can be used.  It's still much more efficient than doing
> the super slow crypto_alloc_shash().
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>

Martin, could you take this via the scsi tree?

Thanks,

- Eric

      parent reply	other threads:[~2026-10-14 16:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01  4:48 [PATCH] scsi: target: iscsi: Use crypto library API Eric Biggers
2026-10-11 12:36 ` David Disseldorp
2026-10-11 19:12   ` Eric Biggers
2026-10-12  1:46     ` David Disseldorp
2026-10-14 16:48 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014164855.GB327771@quark \
    --to=ebiggers@kernel.org \
    --cc=ddiss@suse.de \
    --cc=hossu.alexandru@gmail.com \
    --cc=lduncan@suse.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox