From: Eric Biggers <ebiggers@kernel.org>
To: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
Cc: herbert@gondor.apana.org.au, ardb@kernel.org, Jason@zx2c4.com,
skhan@linuxfoundation.org, me@brighamcampbell.com,
jkoolstra@xs4all.nl, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] lib/crypto: md5: remove unused header
Date: Thu, 15 Oct 2026 17:56:55 +0000 [thread overview]
Message-ID: <20261015175655.GA2170687@google.com> (raw)
In-Reply-To: <20261015060806.5377-1-raizudeen.kerneldev@gmail.com>
On Thu, Oct 15, 2026 at 11:38:06AM +0530, Mohamad Raizudeen wrote:
> The code handles memory accesses using direct pointer casts and
> functions like 'cpu_to_le64()' instead of the unaligned helpers.
This should say "using memcpy() instead of the unaligned helpers". The
actual unaligned accesses in lib/crypto/md5.c are the following:
memcpy(in, data, MD5_BLOCK_SIZE);
le32_to_cpu_array(in, ARRAY_SIZE(in));
and:
cpu_to_le32_array(ctx->state.h, ARRAY_SIZE(ctx->state.h));
memcpy(out, ctx->state.h, MD5_DIGEST_SIZE);
- Eric
prev parent reply other threads:[~2026-10-15 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 6:08 [PATCH v2] lib/crypto: md5: remove unused header Mohamad Raizudeen
2026-10-15 17:56 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015175655.GA2170687@google.com \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jkoolstra@xs4all.nl \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=raizudeen.kerneldev@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox