From: Eric Biggers <ebiggers@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
Stephan Mueller <smueller@chronox.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Sasha Levin <sashal@kernel.org>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 6.1 1069/1887] crypto: jitter - replace LFSR with SHA3-256
Date: Thu, 29 Oct 2026 14:00:38 -0700 [thread overview]
Message-ID: <20261029210038.GB49373@quark> (raw)
In-Reply-To: <20261028170523.734746721@linuxfoundation.org>
[+Cc linux-crypto@vger.kernel.org]
On Wed, Oct 28, 2026 at 05:52:45PM +0100, Greg Kroah-Hartman wrote:
> 6.1-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Stephan Müller <smueller@chronox.de>
>
> [ Upstream commit bb897c55042e9330bcf88b4b13cbdd6f9fabdd5e ]
>
> Using the kernel crypto API, the SHA3-256 algorithm is used as
> conditioning element to replace the LFSR in the Jitter RNG. All other
> parts of the Jitter RNG are unchanged.
For some reason this is going by on stable@ without linux-crypto@ being
Cc'ed, which is itself grounds for a nack.
But also this commit had known bugs that were fixed in follow-up commits
such as 735b72568c73, 908dffaf88a2, 9aa7e045f4af7, maybe others.
Now, these changes were all to the known-problematic and little-used
"FIPS RNG" instead of the regular one. So, ideally, it shouldn't matter
much. The thing is, before v7.1, certain things actually *did* pull
from the "FIPS RNG" even when the kernel wasn't booted with fips=1.
So pulling in known-broken commits to it is a little concerning.
- Eric
next parent reply other threads:[~2026-10-29 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261028170459.200466217@linuxfoundation.org>
[not found] ` <20261028170523.734746721@linuxfoundation.org>
2026-10-29 21:00 ` Eric Biggers [this message]
2026-10-30 20:54 ` [PATCH 6.1 1069/1887] crypto: jitter - replace LFSR with SHA3-256 Sasha Levin
2026-10-30 21:02 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029210038.GB49373@quark \
--to=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=smueller@chronox.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox