From: Eric Biggers <ebiggers@kernel.org>
To: Haoxiang Li <haoxiang_li2024@163.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
johnpol@2ka.mipt.ru, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: hifn_795x - Free walk pages on session setup failure
Date: Tue, 17 Nov 2026 22:55:35 -0800 [thread overview]
Message-ID: <20261118065535.GA95982@sol> (raw)
In-Reply-To: <20261118061917.2093148-1-haoxiang_li2024@163.com>
On Wed, Nov 18, 2026 at 02:19:17PM +0800, Haoxiang Li wrote:
> hifn_setup_session() allocates temporary pages for misaligned destination
> buffers. If the scatterlist walk fails or the hardware queue has
> insufficient capacity, these pages are not released. Retrying a queued
> request reinitializes the walk cache, losing the previous page pointers.
> Add a separate cleanup path to release the pages for misaligned requests.
>
> Fixes: f7d0561ea1da ("[CRYPTO] hifn_795x: HIFN 795x driver")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
> drivers/crypto/hifn_795x.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
We should just delete this driver. It is heavily broken, 32-bit only,
and no one seems to have used it since 2008.
- Eric
prev parent reply other threads:[~2026-11-18 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:19 [PATCH] crypto: hifn_795x - Free walk pages on session setup failure Haoxiang Li
2026-11-18 6:38 ` sashiko-bot
2026-11-18 6:55 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118065535.GA95982@sol \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=haoxiang_li2024@163.com \
--cc=herbert@gondor.apana.org.au \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox