From: Ayush Sawal <ayush.sawal@chelsio.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Devulapally Shiva Krishna <shiva@chelsio.com>
Cc: ayush.sawal@asicdesigners.com,
Vinay Kumar Yadav <vinay.yadav@chelsio.com>,
Rohit Maheshwari <rohitm@chelsio.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Crypto/chcr: drop refcount on error path in chcr_aead_op()
Date: Wed, 13 May 2020 00:48:40 +0530 [thread overview]
Message-ID: <20d2f5c2-d9f0-0016-b33a-5c417dfe9558@chelsio.com> (raw)
In-Reply-To: <20200512083723.GB251760@mwanda>
On 5/12/2020 2:07 PM, Dan Carpenter wrote:
> We need to drop inflight counter before returning on this error path.
>
> Fixes: d91a3159e8d9 ("Crypto/chcr: fix gcm-aes and rfc4106-gcm failed tests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/chelsio/chcr_algo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
> index 83ddc2b39490e..e05998a1c0148 100644
> --- a/drivers/crypto/chelsio/chcr_algo.c
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -3744,6 +3744,7 @@ static int chcr_aead_op(struct aead_request *req,
> crypto_ipsec_check_assoclen(req->assoclen) != 0) {
> pr_err("RFC4106: Invalid value of assoclen %d\n",
> req->assoclen);
> + chcr_dec_wrcount(cdev);
> return -EINVAL;
> }
>
Looks good. Thanks a lot.
prev parent reply other threads:[~2020-05-12 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 8:37 [PATCH] Crypto/chcr: drop refcount on error path in chcr_aead_op() Dan Carpenter
2020-05-12 19:18 ` Ayush Sawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20d2f5c2-d9f0-0016-b33a-5c417dfe9558@chelsio.com \
--to=ayush.sawal@chelsio.com \
--cc=ayush.sawal@asicdesigners.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=shiva@chelsio.com \
--cc=vinay.yadav@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox