From: "Stephan Müller" <smueller@chronox.de>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: AF_ALG: handle 0 lengths in af_alg_make_sg
Date: Sat, 01 Apr 2017 19:46:39 +0200 [thread overview]
Message-ID: <2164576.cSnkze5bYl@positron.chronox.de> (raw)
In-Reply-To: <2380853.MJYDG7HQLD@positron.chronox.de>
Am Samstag, 1. April 2017, 17:04:28 CEST schrieb Stephan Müller:
Hi Herbert,
> Hi Herbert,
>
> If you concur with the patch, I think it should go to 4.11 as well as
> to stable.
After checking this issue again, I see that it is not triggerable in the
current code as the different af_alg users make sure that this function is not
called with 0.
I only triggered this issue during experimenting with the algif_skcipher and
algif_aead revamp as requested by you. During those experiments, I invoked
af_alg_make_sg with a len = 0.
Thus, this patch is not applicable for stable and 4.11.
Yet, I would suggest to consider this patch as a safeguard for any potential
programming errors.
Ciao
Stephan
next prev parent reply other threads:[~2017-04-01 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 15:04 [PATCH] crypto: AF_ALG: handle 0 lengths in af_alg_make_sg Stephan Müller
2017-04-01 17:46 ` Stephan Müller [this message]
2017-04-05 12:50 ` Herbert Xu
2017-04-05 15:51 ` Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2164576.cSnkze5bYl@positron.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox