Re: [PATCH] crypto: rockchip: fix autosuspend cleanup during teardown

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/08/2026 11:30, Guangshuo Li wrote:
> rk_crypto_pm_init() calls pm_runtime_use_autosuspend(), but the
> autosuspend setting is not undone if pm_runtime_set_suspended() fails
> or when runtime PM is later torn down by rk_crypto_pm_exit().
> 
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
> during cleanup, this reference is not dropped and usage_count remains
> unbalanced.
> 
> Undo the autosuspend setting when pm_runtime_set_suspended() fails and
> in rk_crypto_pm_exit() before disabling runtime PM.
> 
> This issue was found by manual code inspection.
> 
> Fixes: a216be3964c1 ("crypto: rockchip - introduce PM")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---

You sent vast amount of patches, all separate, making it very difficult
to track and respond in efficient way. Do not do that.

Group your work per subsystem.

You were asked to clarify and respond to incorrect fixes statement. I do
not see how you clarified and responded at all.

Best regards,
Krzysztof