From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mathias Krause <minipli@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH] crypto: user - re-add size check for CRYPTO_MSG_GETALG
Date: Thu, 23 Jun 2016 16:46:26 +0200 [thread overview]
Message-ID: <2228963.xKdNI3on4m@tauon.atsec.com> (raw)
In-Reply-To: <20160623104357.GA10350@gondor.apana.org.au>
Am Donnerstag, 23. Juni 2016, 18:43:57 schrieb Herbert Xu:
Hi Herbert,
> On Wed, Jun 22, 2016 at 08:29:37PM +0200, Mathias Krause wrote:
> > Commit 9aa867e46565 ("crypto: user - Add CRYPTO_MSG_DELRNG")
> > accidentally removed the minimum size check for CRYPTO_MSG_GETALG
> > netlink messages. This allows userland to send a truncated
> > CRYPTO_MSG_GETALG message as short as a netlink header only making
> > crypto_report() operate on uninitialized memory by accessing data
> > beyond the end of the netlink message.
> >
> > Fix this be re-adding the minimum required size of CRYPTO_MSG_GETALG
> > messages to the crypto_msg_min[] array.
> >
> > Fixes: 9aa867e46565 ("crypto: user - Add CRYPTO_MSG_DELRNG")
> > Cc: stable@vger.kernel.org # v4.2
> > Signed-off-by: Mathias Krause <minipli@googlemail.com>
> > Cc: Steffen Klassert <steffen.klassert@secunet.com>
> > ---
> > This should go on top of crypto-2.6/master.
>
> Patch applied to crypto. Thanks!
Please revert my patch eed1e1afd8d542d9644534c1b712599b5d680007 as requested
by Matthias.
Ciao
Stephan
next prev parent reply other threads:[~2016-06-23 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 18:29 [PATCH] crypto: user - re-add size check for CRYPTO_MSG_GETALG Mathias Krause
2016-06-22 19:03 ` Stephan Mueller
2016-06-22 19:43 ` Mathias Krause
2016-06-23 10:43 ` Herbert Xu
2016-06-23 14:46 ` Stephan Mueller [this message]
2016-06-24 1:00 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2228963.xKdNI3on4m@tauon.atsec.com \
--to=smueller@chronox.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox