From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, Niolai Stange <nstange@suse.com>,
Simo Sorce <simo@redhat.com>
Subject: Re: [PATCH] crypto: HMAC - disallow keys < 112 bits in FIPS mode
Date: Fri, 28 Jan 2022 07:05:33 +0100 [thread overview]
Message-ID: <2285874.XlJOkxW7XW@tauon.chronox.de> (raw)
In-Reply-To: <YfN1HKqL9GT9R25Z@gondor.apana.org.au>
Am Freitag, 28. Januar 2022, 05:46:20 CET schrieb Herbert Xu:
Hi Herbert,
> On Fri, Jan 07, 2022 at 08:25:24PM +0100, Stephan Müller wrote:
> > diff --git a/crypto/testmgr.h b/crypto/testmgr.h
> > index a253d66ba1c1..1c39d294b9ba 100644
> > --- a/crypto/testmgr.h
> > +++ b/crypto/testmgr.h
> > @@ -5706,6 +5706,7 @@ static const struct hash_testvec
> > hmac_sha1_tv_template[] = {>
> > .digest = "\xb6\x17\x31\x86\x55\x05\x72\x64"
> >
> > "\xe2\x8b\xc0\xb6\xfb\x37\x8c\x8e\xf1"
> > "\x46\xbe",
> >
> > +#ifndef CONFIG_CRYPTO_FIPS
> >
> > }, {
> >
> > .key = "Jefe",
> > .ksize = 4,
>
> Please don't use ifdefs, you can instead add a fips_skip setting
> just like we do for cipher test vectors.
Thank you for the hint, will do.
>
> Thanks,
Ciao
Stephan
next prev parent reply other threads:[~2022-01-28 6:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 19:25 [PATCH] crypto: HMAC - disallow keys < 112 bits in FIPS mode Stephan Müller
2022-01-07 23:28 ` Eric Biggers
2022-01-08 6:39 ` Stephan Müller
2022-01-11 7:17 ` Stephan Mueller
2022-01-28 4:46 ` Herbert Xu
2022-01-28 6:05 ` Stephan Mueller [this message]
2022-02-01 8:40 ` [PATCH v2 0/2] " Stephan Müller
2022-02-01 8:40 ` [PATCH v2 1/2] crypto: HMAC - add fips_skip support Stephan Müller
2022-02-01 8:41 ` [PATCH v2 2/2] crypto: HMAC - disallow keys < 112 bits in FIPS mode Stephan Müller
2022-02-11 9:34 ` [PATCH v2 0/2] " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2285874.XlJOkxW7XW@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=nstange@suse.com \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox