From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Adrian Hoban <adrian.hoban@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
Timothy McCaffrey <timothy.mccaffrey@unisys.com>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [v3 PATCH] crypto: aesni - Convert rfc4106 to new AEAD interface
Date: Mon, 01 Jun 2015 11:04:39 +0200 [thread overview]
Message-ID: <2306645.epOL7FXtYn@tauon> (raw)
In-Reply-To: <20150601075306.GA11725@gondor.apana.org.au>
Am Montag, 1. Juni 2015, 15:53:06 schrieb Herbert Xu:
Hi Herbert,
>On Mon, Jun 01, 2015 at 03:50:22PM +0800, Herbert Xu wrote:
>> This patch converts the low-level __gcm-aes-aesni algorithm to
>> the new AEAD interface.
>
>Oops, I missed two more spots.
That patch fixes the crash. Thanks
Just FYI: when testing rfc4106(gcm(aes-aesni)) with the old givcipher API, I
got a crash in my code invoking the cipher which used to work in older kernels
and which works with the C implementations. So, there must be some change in
how givcipher is treated by the AESNI implementation.
As this API is sunset now, shall I dig deeper or shall we simply deactivate
the API entirely?
--
Ciao
Stephan
next prev parent reply other threads:[~2015-06-01 9:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150528133700.GA7822@gondor.apana.org.au>
2015-05-28 14:03 ` [PATCH 0/10] crypto: Convert pcrypt/cryptd/aesni to new AEAD interface Herbert Xu
2015-05-28 14:07 ` [PATCH 1/10] crypto: aead - Add type-safe init/exit functions Herbert Xu
2015-05-28 14:07 ` [PATCH 2/10] crypto: aead - Add aead_alg_instance Herbert Xu
2015-05-28 14:07 ` [PATCH 3/10] crypto: api - Include alignment in crypto_alg_extsize Herbert Xu
2015-05-28 14:07 ` [PATCH 4/10] crypto: aead - Ignore return value from crypto_unregister_alg Herbert Xu
2015-05-28 14:07 ` [PATCH 5/10] crypto: aead - Add multiple algorithm registration interface Herbert Xu
2015-05-28 14:08 ` [PATCH 6/10] crypto: pcrypt - Add support for new AEAD interface Herbert Xu
2015-05-28 14:08 ` [PATCH 7/10] crypto: cryptd - Add setkey/setauthsize functions for AEAD Herbert Xu
2015-05-28 14:08 ` [PATCH 8/10] crypto: aesni - Convert top-level rfc4106 algorithm to new interface Herbert Xu
2015-05-29 21:39 ` Stephan Mueller
2015-05-29 21:50 ` Stephan Mueller
2015-06-01 7:41 ` Herbert Xu
2015-05-28 14:08 ` [PATCH 9/10] crypto: cryptd - Convert to new AEAD interface Herbert Xu
2015-05-28 14:08 ` [PATCH 10/10] crypto: aesni - Convert rfc4106 " Herbert Xu
2015-05-30 11:17 ` Stephan Mueller
2015-06-01 7:50 ` [v2 PATCH] " Herbert Xu
2015-06-01 7:53 ` [v3 " Herbert Xu
2015-06-01 9:04 ` Stephan Mueller [this message]
2015-06-01 9:09 ` Herbert Xu
2015-06-01 9:44 ` Stephan Mueller
2015-06-01 9:52 ` Herbert Xu
2015-06-01 10:08 ` Stephan Mueller
[not found] ` <E1YxyQL-0002Ha-OL@gondolin.me.apana.org.au>
2015-05-28 21:23 ` [PATCH 10/10] " Tim Chen
2015-05-29 0:29 ` Herbert Xu
2015-05-29 17:32 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2306645.epOL7FXtYn@tauon \
--to=smueller@chronox.de \
--cc=adrian.hoban@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tadeusz.struk@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=timothy.mccaffrey@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox