Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mike Mestnik <cheako@mikemestnik.net>,
	linux-crypto@vger.kernel.org,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Theodore Ts'o <tytso@mit.edu>
Subject: Re: USB HID devices not linked to RNG
Date: Wed, 09 Sep 2015 14:24:54 +0200	[thread overview]
Message-ID: <2407745.gnJxkiQhnm@tauon.atsec.com> (raw)
In-Reply-To: <CAKdAkRRYKi+P9NTaKuDm+OeXh6YoP4Atf3V1NR3miioFHAchhQ@mail.gmail.com>

Am Dienstag, 8. September 2015, 22:40:07 schrieb Dmitry Torokhov:

Hi Dmitry,

>
>All input devices add randomness, however I think for mouse
>add_input_randomness() will drop majority of events since they are
>likely have the same value (well, depends on which direction you are
>moving the mouse)...

I agree that such mechanism is present, but it is implemented by 
add_input_randomness:

        /* ignore autorepeat and the like */
        if (value == last_value)
                return;

So, when we install a probe at the entry into add_input_randomness, we should 
see invocations.

The problem now is that add_input_randomness is not called at all.

Simply use the following code as a systemtap script, load it and move a USB 
mouse or type on a USB keyboard:

probe kernel.function("add_input_randomness") {
	printf("add_input_randomness triggered\n");
}

Expected behavior: tons of printouts should be received (as it is the case 
with PS/2 mice and keyboards).

Actual behavior: no printout when moving USB HID.


Ciao
Stephan

      reply	other threads:[~2015-09-09 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  0:10 USB HID devices not linked to RNG Stephan Mueller
2015-09-07  0:12 ` Stephan Mueller
2015-09-07 20:07   ` Mike Mestnik
2015-09-07 21:09     ` Stephan Mueller
2015-09-09  5:40       ` Dmitry Torokhov
2015-09-09 12:24         ` Stephan Mueller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2407745.gnJxkiQhnm@tauon.atsec.com \
    --to=smueller@chronox.de \
    --cc=cheako@mikemestnik.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox