Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: weiyj_lk@163.com
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning
Date: Wed, 14 Jan 2015 04:11:14 +0100	[thread overview]
Message-ID: <2495791.u1JdGytR9n@tachyon.chronox.de> (raw)
In-Reply-To: <1421198081-16766-1-git-send-email-weiyj_lk@163.com>

Am Mittwoch, 14. Januar 2015, 09:14:41 schrieb weiyj_lk@163.com:

Hi,

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fixes the following sparse warnings:
> 
> crypto/algif_rng.c:185:13: warning:
>  symbol 'rng_exit' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Stephan Mueller <smueller@chronox.de>
> ---
>  crypto/algif_rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/algif_rng.c b/crypto/algif_rng.c
> index 91c06f5..67f612c 100644
> --- a/crypto/algif_rng.c
> +++ b/crypto/algif_rng.c
> @@ -182,7 +182,7 @@ static int __init rng_init(void)
>  	return af_alg_register_type(&algif_type_rng);
>  }
> 
> -void __exit rng_exit(void)
> +static void __exit rng_exit(void)
>  {
>  	int err = af_alg_unregister_type(&algif_type_rng);
>  	BUG_ON(err);


-- 
Ciao
Stephan

  reply	other threads:[~2015-01-14  3:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  1:14 [PATCH -next] crypto: algif_rng - fix sparse non static symbol warning weiyj_lk
2015-01-14  3:11 ` Stephan Mueller [this message]
2015-01-14  9:43 ` Neil Horman
2015-01-14 11:00 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2495791.u1JdGytR9n@tachyon.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=weiyj_lk@163.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox