From: Paulo Alcantara <pc@manguebit.com>
To: Eric Biggers <ebiggers@kernel.org>,
Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] smb: use crypto_shash_digest() in symlink_hash()
Date: Tue, 31 Oct 2023 11:57:33 -0300 [thread overview]
Message-ID: <24f65f57980f7010cdc44f17023d475b.pc@manguebit.com> (raw)
In-Reply-To: <20231029050300.154832-1-ebiggers@kernel.org>
Eric Biggers <ebiggers@kernel.org> writes:
> From: Eric Biggers <ebiggers@google.com>
>
> Simplify symlink_hash() by using crypto_shash_digest() instead of an
> init+update+final sequence. This should also improve performance.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/smb/client/link.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/fs/smb/client/link.c b/fs/smb/client/link.c
> index c66be4904e1f..a1da50e66fbb 100644
> --- a/fs/smb/client/link.c
> +++ b/fs/smb/client/link.c
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
prev parent reply other threads:[~2023-10-31 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 5:03 [PATCH] smb: use crypto_shash_digest() in symlink_hash() Eric Biggers
2023-10-30 1:10 ` Steve French
2023-10-31 14:57 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f65f57980f7010cdc44f17023d475b.pc@manguebit.com \
--to=pc@manguebit.com \
--cc=ebiggers@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox