Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: AF_ALG - fix AEAD AIO handling of zero buffer
Date: Wed, 07 Dec 2016 13:29:13 +0100	[thread overview]
Message-ID: <2633671.N2joko3Rba@tauon.atsec.com> (raw)
In-Reply-To: <20161201132207.GF2249@gondor.apana.org.au>

Am Donnerstag, 1. Dezember 2016, 21:22:07 CET schrieb Herbert Xu:

Hi Herbert,

> On Thu, Dec 01, 2016 at 08:22:37AM +0100, Stephan Mueller wrote:
> > Hi Herbert,
> > 
> > I split out the bug fix patch from the AD/tag formatting patch as they
> > most likely will come after the next merge window.
> > 
> > ---8<---
> > 
> > Handle the case when the caller provided a zero buffer to
> > sendmsg/sendpage. Such scenario is legal for AEAD ciphers when no
> > plaintext / ciphertext and no AAD is provided and the caller only
> > requests the generation of the tag value.
> > 
> > Signed-off-by: Stephan Mueller <smueller@chronox.de>
> 
> Patch applied.  Thanks.

May I suggest to forward that patch to stable as this patch fixes a kernel 
crasher that can be triggered by an unprivileged user?

The bug was introduced in 4.7 with the AEAD AIO addition.

Ciao
Stephan

      reply	other threads:[~2016-12-07 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01  7:22 [PATCH v2] crypto: AF_ALG - fix AEAD AIO handling of zero buffer Stephan Mueller
2016-12-01 13:22 ` Herbert Xu
2016-12-07 12:29   ` Stephan Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2633671.N2joko3Rba@tauon.atsec.com \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox