Re: [PATCH v10 2/5] s390/crypto: New s390 specific protected key hash phmac

[Harald Freudenberger <freude@linux.ibm.com>]

On 2025-01-15 17:22, Harald Freudenberger wrote:
> Add support for protected key hmac ("phmac") for s390 arch.
> 
> With the latest machine generation there is now support for
> protected key (that is a key wrapped by a master key stored
> in firmware) hmac for sha2 (sha224, sha256, sha384 and sha512)
> for the s390 specific CPACF instruction kmac.
> 
> This patch adds support via 4 new ahashes registered as
> phmac(sha224), phmac(sha256), phmac(sha384) and phmac(sha512).
> 
> Co-developed-by: Holger Dengler <dengler@linux.ibm.com>
> Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
> ---

...

> +
> +	  Select this option if you want to use the phmac digests
> +	  for example to use dm-integrity with secure/protected keys.
> +
>  config S390_PRNG
>  	tristate "Pseudo random number generator device driver"
>  	depends on S390

Hello Eric

with your commit
   7fa481734016 crypto: ahash - make hash walk functions private to 
ahash.c
you move the crypto_hash_walk_* functions to private context into 
ahash.c.
So for example my new phmac does not compile any more.
What is the replacement for these functions then? Should I really do
the scatter walk by my own now or is there a set of new functions to 
come?