From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 1/2] w1: ds2406: use crc16() instead of crc16_byte() loop
Date: Tue, 13 May 2025 09:52:37 +0200 [thread overview]
Message-ID: <271da1c2-c322-4568-b484-c368e5e0ae7c@kernel.org> (raw)
In-Reply-To: <20250513022115.39109-2-ebiggers@kernel.org>
On 13/05/2025 04:21, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Instead of looping through each byte and calling crc16_byte(), instead
> just call crc16() on the whole buffer. No functional change.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> drivers/w1/slaves/w1_ds2406.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-13 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 2:21 [PATCH 0/2] lib/crc16: unexport crc16_table and crc16_byte() Eric Biggers
2025-05-13 2:21 ` [PATCH 1/2] w1: ds2406: use crc16() instead of crc16_byte() loop Eric Biggers
2025-05-13 7:52 ` Krzysztof Kozlowski [this message]
2025-05-13 2:21 ` [PATCH 2/2] lib/crc16: unexport crc16_table and crc16_byte() Eric Biggers
2025-05-13 9:42 ` [PATCH 0/2] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271da1c2-c322-4568-b484-c368e5e0ae7c@kernel.org \
--to=krzk@kernel.org \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox