public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>,
	linux-nfs@vger.kernel.org, Chuck Lever	 <chuck.lever@oracle.com>,
	Trond Myklebust <trondmy@kernel.org>,
	Anna Schumaker	 <anna@kernel.org>
Cc: linux-crypto@vger.kernel.org, NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it
Date: Sat, 06 Sep 2025 19:50:18 -0400	[thread overview]
Message-ID: <27fb8a0fdef3ecd3fb708e557c5e0115fc318337.camel@kernel.org> (raw)
In-Reply-To: <20250906230019.94569-1-ebiggers@kernel.org>

On Sat, 2025-09-06 at 16:00 -0700, Eric Biggers wrote:
> Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it.  This
> unblocks the eventual removal of the selection of CRYPTO from NFSD_V4,
> which will no longer be needed by nfsd itself due to switching to the
> crypto library functions.  But NFSD_V4 selects RPCSEC_GSS_KRB5, which
> still needs CRYPTO.  It makes more sense for RPCSEC_GSS_KRB5 to select
> CRYPTO itself, like most other kconfig options that need CRYPTO do.
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>  net/sunrpc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
> index 2d8b67dac7b5b..33aafdc8392e3 100644
> --- a/net/sunrpc/Kconfig
> +++ b/net/sunrpc/Kconfig
> @@ -16,13 +16,14 @@ config SUNRPC_SWAP
>  	bool
>  	depends on SUNRPC
>  
>  config RPCSEC_GSS_KRB5
>  	tristate "Secure RPC: Kerberos V mechanism"
> -	depends on SUNRPC && CRYPTO
> +	depends on SUNRPC
>  	default y
>  	select SUNRPC_GSS
> +	select CRYPTO
>  	select CRYPTO_SKCIPHER
>  	select CRYPTO_HASH
>  	help
>  	  Choose Y here to enable Secure RPC using the Kerberos version 5
>  	  GSS-API mechanism (RFC 1964).
> 
> base-commit: 4a0de50a44bb11ea67bb3ca961844b55ac57cf05

Acked-by: Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2025-09-06 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-06 23:00 [PATCH] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it Eric Biggers
2025-09-06 23:50 ` Jeff Layton [this message]
2025-09-08 14:36 ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27fb8a0fdef3ecd3fb708e557c5e0115fc318337.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox