[PATCH] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

[PATCH] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

[Eric Biggers]

Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it.  This
unblocks the eventual removal of the selection of CRYPTO from NFSD_V4,
which will no longer be needed by nfsd itself due to switching to the
crypto library functions.  But NFSD_V4 selects RPCSEC_GSS_KRB5, which
still needs CRYPTO.  It makes more sense for RPCSEC_GSS_KRB5 to select
CRYPTO itself, like most other kconfig options that need CRYPTO do.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
 net/sunrpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
index 2d8b67dac7b5b..33aafdc8392e3 100644
--- a/net/sunrpc/Kconfig
+++ b/net/sunrpc/Kconfig
@@ -16,13 +16,14 @@ config SUNRPC_SWAP
 	bool
 	depends on SUNRPC
 
 config RPCSEC_GSS_KRB5
 	tristate "Secure RPC: Kerberos V mechanism"
-	depends on SUNRPC && CRYPTO
+	depends on SUNRPC
 	default y
 	select SUNRPC_GSS
+	select CRYPTO
 	select CRYPTO_SKCIPHER
 	select CRYPTO_HASH
 	help
 	  Choose Y here to enable Secure RPC using the Kerberos version 5
 	  GSS-API mechanism (RFC 1964).

base-commit: 4a0de50a44bb11ea67bb3ca961844b55ac57cf05
-- 
2.50.1

Re: [PATCH] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

[Jeff Layton]

On Sat, 2025-09-06 at 16:00 -0700, Eric Biggers wrote:
> Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it.  This
> unblocks the eventual removal of the selection of CRYPTO from NFSD_V4,
> which will no longer be needed by nfsd itself due to switching to the
> crypto library functions.  But NFSD_V4 selects RPCSEC_GSS_KRB5, which
> still needs CRYPTO.  It makes more sense for RPCSEC_GSS_KRB5 to select
> CRYPTO itself, like most other kconfig options that need CRYPTO do.
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>  net/sunrpc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
> index 2d8b67dac7b5b..33aafdc8392e3 100644
> --- a/net/sunrpc/Kconfig
> +++ b/net/sunrpc/Kconfig
> @@ -16,13 +16,14 @@ config SUNRPC_SWAP
>  	bool
>  	depends on SUNRPC
>  
>  config RPCSEC_GSS_KRB5
>  	tristate "Secure RPC: Kerberos V mechanism"
> -	depends on SUNRPC && CRYPTO
> +	depends on SUNRPC
>  	default y
>  	select SUNRPC_GSS
> +	select CRYPTO
>  	select CRYPTO_SKCIPHER
>  	select CRYPTO_HASH
>  	help
>  	  Choose Y here to enable Secure RPC using the Kerberos version 5
>  	  GSS-API mechanism (RFC 1964).
> 
> base-commit: 4a0de50a44bb11ea67bb3ca961844b55ac57cf05

Acked-by: Jeff Layton <jlayton@kernel.org>

Re: [PATCH] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it

[Chuck Lever]

From: Chuck Lever <chuck.lever@oracle.com>

On Sat, 06 Sep 2025 16:00:19 -0700, Eric Biggers wrote:
> Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it.  This
> unblocks the eventual removal of the selection of CRYPTO from NFSD_V4,
> which will no longer be needed by nfsd itself due to switching to the
> crypto library functions.  But NFSD_V4 selects RPCSEC_GSS_KRB5, which
> still needs CRYPTO.  It makes more sense for RPCSEC_GSS_KRB5 to select
> CRYPTO itself, like most other kconfig options that need CRYPTO do.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] SUNRPC: Make RPCSEC_GSS_KRB5 select CRYPTO instead of depending on it
      commit: b3560ad8e52b87cdbd858ec279429276695c1e48

--
Chuck Lever