From: Stephan Mueller <stephan.mueller@atsec.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Jarod Wilson <jarod@redhat.com>,
linux-kernel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto/fips: only panic on bad/missing crypto mod signatures
Date: Thu, 03 Jul 2014 16:10:07 +0200 [thread overview]
Message-ID: <2891603.xs6W2pOOfS@tauon> (raw)
In-Reply-To: <20140703111806.GE9748@hmsreliant.think-freely.org>
Am Donnerstag, 3. Juli 2014, 07:18:06 schrieb Neil Horman:
>On Wed, Jul 02, 2014 at 03:37:30PM -0400, Jarod Wilson wrote:
>> Per further discussion with NIST, the requirements for FIPS state
>> that
>> we only need to panic the system on failed kernel module signature
>> checks for crypto subsystem modules. This moves the fips-mode-only
>> module signature check out of the generic module loading code, into
>> the crypto subsystem, at points where we can catch both algorithm
>> module loads and mode module loads. At the same time, make
>> CONFIG_CRYPTO_FIPS dependent on CONFIG_MODULE_SIG, as this is
>> entirely necessary for FIPS mode.
>>
>> v2: remove extraneous blank line, perform checks in static inline
>> function, drop no longer necessary fips.h include.
>>
>> CC: Herbert Xu <herbert@gondor.apana.org.au>
>> CC: "David S. Miller" <davem@davemloft.net>
>> CC: Rusty Russell <rusty@rustcorp.com.au>
>> CC: Stephan Mueller <stephan.mueller@atsec.com>
>> CC: linux-crypto@vger.kernel.org
>> Signed-off-by: Jarod Wilson <jarod@redhat.com>
>
>Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Stephan Mueller <stephan.mueller@atsec.com>
next prev parent reply other threads:[~2014-07-03 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 19:12 [PATCH] crypto/fips: only panic on bad/missing crypto mod signatures Jarod Wilson
2014-06-27 19:19 ` Jarod Wilson
2014-07-02 12:38 ` Herbert Xu
2014-07-02 13:53 ` Jarod Wilson
2014-07-02 19:37 ` [PATCH v2] " Jarod Wilson
2014-07-03 11:18 ` Neil Horman
2014-07-03 14:10 ` Stephan Mueller [this message]
2014-07-03 13:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2891603.xs6W2pOOfS@tauon \
--to=stephan.mueller@atsec.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarod@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).