From: Stephan Mueller <smueller@chronox.de>
To: Benjamin Warnke <4bwarnke@informatik.uni-hamburg.de>
Cc: linux-crypto@vger.kernel.org
Subject: Re: Subject: [PATCH] crypto: add zbewalgo compression algorithm for zram
Date: Tue, 30 Jan 2018 18:59:17 +0100 [thread overview]
Message-ID: <2893047.8sTGZPTY3e@tauon.chronox.de> (raw)
In-Reply-To: <450300D8-6A7C-4D63-971A-AB6279C3B3DD@informatik.uni-hamburg.de>
Am Dienstag, 30. Januar 2018, 16:08:57 CET schrieb Benjamin Warnke:
Hi Benjamin,
Please run checkpatch.pl on the patch and fix the formatting issues.
In general: I do not think that having larger C functions in header files is a
proper coding style. Also, having static variables header files is also not
nice.
Do not redefine code that already exists. For example, MIN/MAX exists: min_t
and max_t.
Why are there __attribute__ ((unused)) function parameters, such as in
compress_bitshuffle and others?
Ciao
Stephan
next prev parent reply other threads:[~2018-01-30 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 15:08 Subject: [PATCH] crypto: add zbewalgo compression algorithm for zram Benjamin Warnke
2018-01-30 17:59 ` Stephan Mueller [this message]
2018-01-30 19:50 ` Benjamin Warnke
[not found] ` <C1EF6641-08EB-436C-AD2A-F2581A5BE3FE@informatik.uni-hamburg.de>
2018-01-30 21:26 ` Stephan Müller
2018-01-30 21:37 ` Benjamin Warnke
2018-01-31 6:40 ` Benjamin Warnke
2018-01-31 8:36 ` Benjamin Warnke
2018-01-30 20:24 ` Eric Biggers
2018-01-30 21:27 ` Benjamin Warnke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2893047.8sTGZPTY3e@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=4bwarnke@informatik.uni-hamburg.de \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox