From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D63C4363A for ; Mon, 5 Oct 2020 07:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BEEC20774 for ; Mon, 5 Oct 2020 07:45:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=chronox.de header.i=@chronox.de header.b="U3oczptI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725880AbgJEHpk (ORCPT ); Mon, 5 Oct 2020 03:45:40 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.54]:29209 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgJEHpk (ORCPT ); Mon, 5 Oct 2020 03:45:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1601883938; s=strato-dkim-0002; d=chronox.de; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=JI6A9PpIQFNnYPSlFbk1aFwk9N6qbShlSuz0WnZt37Q=; b=U3oczptIrcqNUK/Sdc39uV2WTuCkl8Yzic2rXHSG3LotVotGo4uRjMOcrlWLikPrn8 uQZkmh67FdzT516GT/0vcni/3EZ1OHvwWLaUrBm7hz8Q/XE16SO75g/xos71SQ3nHYkX w1WvdpxuOqG4Fo4WQcDdfs3PS+d0F92bG/KcFzx5KVgOQLa9SpgbxZ2qBYESFLGW0ZWB LAYljgxJF19kaMeOfJzAnL6W2DZQFT4zr5d16bAholY3o4Le+NEDDgPh9A9vi3syzUP3 JCnXNzkHeF2vVTRWGKLU8K80SEHPLzGNy50nmu/AxX3zKZuv3mlbMP4s0rie3JHdChFK jL2A== X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXPZJfSYkOI=" X-RZG-CLASS-ID: mo00 Received: from tauon.chronox.de by smtp.strato.de (RZmta 47.2.1 DYNA|AUTH) with ESMTPSA id C0b627w957jYBRk (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 5 Oct 2020 09:45:34 +0200 (CEST) From: Stephan Mueller To: Ard Biesheuvel Cc: Christoph Hellwig , Palmer Dabbelt , linux-riscv , Android Kernel Team , kernel test robot , Linux Crypto Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] crypto: jitterentropy - bind statically into kernel Date: Mon, 05 Oct 2020 09:45:33 +0200 Message-ID: <2961600.L5xXbe6F5v@tauon.chronox.de> In-Reply-To: References: <20200930065617.934638-1-palmerdabbelt@google.com> <2588700.mWSkj6HvKX@tauon.chronox.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Montag, 5. Oktober 2020, 08:44:39 CEST schrieb Ard Biesheuvel: Hi Ard, > On Mon, 5 Oct 2020 at 08:40, Stephan Mueller wrote: > > Am Montag, 5. Oktober 2020, 08:24:46 CEST schrieb Ard Biesheuvel: > > > > Hi Ard, > > > > > If jitterentropy is a special case, we could put a alternate > > > non-'static inline' version of random_get_entropy() in the core > > > kernel, and only export it if JITTER_ENTROPY is built as a module in > > > the first place. But I'd prefer it if jitterentropy switches to an API > > > that is suitable for driver consumption. > > > > Which API do you have in mind? In user space, I use > > clock_gettime(CLOCK_REALTIME) which also considers the clock source. > > AFAICT, that call is backed by ktime_get_real_ts64(), which is already > being exported to modules. > > Could you please check whether that works for your driver? Yes, will do. Thanks. Ciao Stephan