From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] crypto: picoxcell - Fix module autoload for non-OF registration Date: Mon, 02 Jan 2017 17:24:54 +0100 Message-ID: <2972455.z8LBYOSBAA@wuerfel> References: <1483371482-4956-1-git-send-email-javier@osg.samsung.com> <2761495.aqgObxUbGB@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Herbert Xu , linux-crypto@vger.kernel.org, Jamie Iles , "David S. Miller" To: Javier Martinez Canillas Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Monday, January 2, 2017 1:13:24 PM CET Javier Martinez Canillas wrote: > Hello Arnd, > > On 01/02/2017 01:05 PM, Arnd Bergmann wrote: > > On Monday, January 2, 2017 12:38:02 PM CET Javier Martinez Canillas wrote: > >> If the driver is built as a module, autoload won't work because the module > >> alias information is not filled. So user-space can't match the registered > >> device with the corresponding module if the device isn't registered via OF. > >> > >> Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > > > I think we can just remove the table, as the platform only supports > > booting through DT anyway. > > > > Agreed. I should had checked if mach-picoxcell was DT-only indeed. > > Should I also make the driver to depend on OF and remove the #ifdefery then? I don't think we need a dependency, the #ifdef checks in there were needed only to make the driver smaller if OF is disabled and it should still build fine if someone tries to compile it for CONFIG_COMPILE_TEST without CONFIG_OF. If we remove the platform ID, we can however also remove the spacc_is_compatible() function and just call of_device_is_compatible() in its place. Arnd