Re: [PATCH] s390: crypto: add select CRYPTO_AEAD for aes

[Harald Freudenberger <freude@linux.ibm.com>]

On 2026-05-20 09:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The aes driver registers both skcipher and aead algorithms,
> but when aead is not enabled this causes a link failure:
> 
> s390-linux-ld: arch/s390/crypto/aes_s390.o: in function 
> `aes_s390_fini':
> arch/s390/crypto/aes_s390.c:969:(.text+0x115e): undefined reference to
> `crypto_unregister_aead'
> s390-linux-ld: arch/s390/crypto/aes_s390.o: in function 
> `aes_s390_init':
> arch/s390/crypto/aes_s390.c:1028:(.init.text+0x294): undefined
> reference to `crypto_register_aead'
> 
> Add the missing 'select' statement.
> 
> Fixes: bf7fa038707c ("s390/crypto: add s390 platform specific aes gcm 
> support.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/s390/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/s390/crypto/Kconfig b/arch/s390/crypto/Kconfig
> index 00051d27db95..228570a1b233 100644
> --- a/arch/s390/crypto/Kconfig
> +++ b/arch/s390/crypto/Kconfig
> @@ -4,6 +4,7 @@ menu "Accelerated Cryptographic Algorithms for CPU 
> (s390)"
> 
>  config CRYPTO_AES_S390
>  	tristate "Ciphers: AES, modes: ECB, CBC, CTR, XTS, GCM"
> +	select CRYPTO_AEAD
>  	select CRYPTO_SKCIPHER
>  	help
>  	  AEAD cipher: AES with GCM

Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>