Linux cryptographic layer development
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: Harsh Jain <harsh@chelsio.com>
Cc: herbert@gondor.apana.org.au, atul.gupta@chelsio.com,
	harshjain.prof@gmail.com, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/1] crypto:algif_aead - Fix kernel panic on list_del
Date: Wed, 01 Feb 2017 16:47:56 +0100	[thread overview]
Message-ID: <32306312.dDnCIAjQMB@tauon.atsec.com> (raw)
In-Reply-To: <3368ebb31bd1670b8ea8ff45c81807c8c0e6bc3b.1485948732.git.harsh@chelsio.com>

Am Mittwoch, 1. Februar 2017, 21:10:28 CET schrieb Harsh Jain:

Hi Harsh,

> Kernel panics when userspace program try to access AEAD interface.
> Remove node from Linked List before freeing its memory.

Very good catch. Thank you.

Reviewed-by: Stephan Müller <smueller@chronox.de>

(PS: Herbert, in case you want to apply my patches regarding fixing the memory 
management for algif_aead and algif_skcipher, please note that this error is 
in the new function aead_free_rsgl/skcipher_free_sgl. Thus, if you think that 
my approach is good after all, I will need to re-send the patch.)

Ciao
Stephan

      reply	other threads:[~2017-02-01 15:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 15:40 [PATCH 1/1] crypto:algif_aead - Fix kernel panic on list_del Harsh Jain
2017-02-01 15:47 ` Stephan Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32306312.dDnCIAjQMB@tauon.atsec.com \
    --to=smueller@chronox.de \
    --cc=atul.gupta@chelsio.com \
    --cc=harsh@chelsio.com \
    --cc=harshjain.prof@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox