From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC66D58203 for ; Tue, 2 Apr 2024 09:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712051294; cv=none; b=EU65oJdDLCZnAPOo+VY0jBXm3hHvT4ZORG16Ahb68OmuuoiFYmlOOzlppfEX1KogxJqcgusfxcPfDx/QlY99z93BrxXjhsXKn9eJmsMn1h9+EIDtTIrMMmxz8ng4MQXGZOTIs/tfF0lX+1b/btwS/YKpNZzS4lPrnLeO/UBjYZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712051294; c=relaxed/simple; bh=icRvQS7M6rvzrlGeqeriHDHruQ0N6yuUR50nC5ZmANo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XGOXEbXfSVKbY7hQgoDHpZT/FsyCBVaPlRk9+oY8FJoIeP2X+b76SoAwcE++Ni43hrGei7AktWsTrSB2Z6I0HsJPZ+jsNdOZNqt24qSqSh/8PstWWsvQqlbmz2nlUINtWzwREKYY5V4UYOiou/6m+K6PLI5SYDOGmhkuAj//ryg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y8+OhulH; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y8+OhulH" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a46cd9e7fcaso630646766b.1 for ; Tue, 02 Apr 2024 02:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712051291; x=1712656091; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=2sz48q8t12VAjxd/9AdQNmu9otPht69ziWcxN5aYwFo=; b=y8+OhulHqta/XFBdSeJzDdw73V4zWpBX7MEU7oJ32gtTI3mD5zVHaDFNh0YySXQQXT yg5MZagJM/biSA/zkEy9E1jedjXi6tdh52R+28kmQd273ew4+jFTXRTVaB59AcCa0Uv7 JfF4YmViP8CqzPwJRKRY+WXpnUGc/m/kgw3lPOAapybaQeV/wNrY9Qhi8tW+cmYZI9Z6 reE3wtErFiNgyR0PyOywLGg8lI7s8gsw87F0+N7l34ZzxTYoCWikt3QJU6PSs/xo2eCq l5CmTR55akcKP8xeUfiwGa9rS2mrDMZr/ANYbmLfDLvzvWjND9XQ9JBv1SbNOJ4o4VE9 jo0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712051291; x=1712656091; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2sz48q8t12VAjxd/9AdQNmu9otPht69ziWcxN5aYwFo=; b=VebSStVPGMMA74GsCX/ykMux0OsHHJqVDDs/QdCHZm9PPH0hUozcyLjAVvjCAlhEYI I42DgpP+zSfz6gudNUcmFFMZkMK4OTjwAb4vcTVMl4On7Z9ehxSNpF3shBTF8WKkVOxm j3n5t77KQjjmlHI6PNzhSu+0DrA1ZIY96B9ofS8S1H3rGOCexPe+qXmm39rQx1+K6e9A uIKysUdAGtNxvegr+RHfUnbN/WvTgI99x0B8cUuKsx7atCnjesLbwmFSmbaFMH7JiePt +EvuGs9TmfGrQA7e04VIRalMxuu9Zlp+bmb1ztcyALwNR+iG6oPpR35QhGDZWL+ioCGO ALyw== X-Forwarded-Encrypted: i=1; AJvYcCVarhK1duLOSaWfYOPozV6T2kLYEkaPYjbaZXXX4JcTpS0V3nS1EYY/VPIU8sntOYctn9RwWXuVzVUUDf0J8MWHHLFA02WVrBhUzXTl X-Gm-Message-State: AOJu0Yw9fUa0TeLK9D8e/ONd/d9qBYfhkn29dS4zyxRWhdz2gEOdeAaR xu+ROlY6FemHJdOGmvrqL4aum29K9kHg0loUx/kUoJoRrGI//BAl3Rm5/xLWR5c= X-Google-Smtp-Source: AGHT+IF2NogpPqBNvyrR1zcHjbhJk2XG5tvD6ivUrERteThTeF3BX1JrsGweDRwkBIK7KneO6GTUzw== X-Received: by 2002:a17:906:bf2:b0:a47:df55:cf6c with SMTP id z18-20020a1709060bf200b00a47df55cf6cmr9253414ejg.63.1712051291217; Tue, 02 Apr 2024 02:48:11 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id u10-20020a17090663ca00b00a4e8991cfbfsm586473ejk.127.2024.04.02.02.48.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 02:48:10 -0700 (PDT) Message-ID: <324e9c02-c005-4e18-9872-8408695fb1fe@linaro.org> Date: Tue, 2 Apr 2024 11:48:08 +0200 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/19] amba: store owner from modules with amba_driver_register() To: "Russell King (Oracle)" Cc: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Andi Shyti , Olivia Mackall , Herbert Xu , Vinod Koul , Dmitry Torokhov , Miquel Raynal , Michal Simek , Eric Auger , Alex Williamson , linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-i2c@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-input@vger.kernel.org, kvm@vger.kernel.org References: <20240326-module-owner-amba-v1-0-4517b091385b@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/04/2024 10:56, Russell King (Oracle) wrote: > On Sat, Mar 30, 2024 at 01:18:30PM +0100, Krzysztof Kozlowski wrote: >> On 26/03/2024 21:23, Krzysztof Kozlowski wrote: >>> Merging >>> ======= >>> All further patches depend on the first amba patch, therefore please ack >>> and this should go via one tree. >>> >>> Description >>> =========== >>> Modules registering driver with amba_driver_register() often forget to >>> set .owner field. >>> >>> Solve the problem by moving this task away from the drivers to the core >>> amba bus code, just like we did for platform_driver in commit >>> 9447057eaff8 ("platform_device: use a macro instead of >>> platform_driver_register"). >>> >>> Best regards, >> >> I tried to submit this series to Russell patch tracker and failed. This >> is ridiculous. It's 2024 and instead of normal process, like every other >> maintainer, so b4 or Patchwork, we have some unusable system rejecting >> standard patches. > > Sorry but no. Stop being offensive. > >> First, it depends some weird, duplicated signed-off-by's. > > Eh? There is no such logic in there. In the web system there is - read the error message I pasted. It wants another SoB from the unrelated email account, the one used purely for registering in some web system, not the one used for code handling. > >> Second it > submitting patch-by-patch, all with clicking on some web >> (!!!) interface. > > Again, no it doesn't, and you're just throwing crap out because you > failed. Unlike most of the "normal" processes, the patch system allows > you to submit both by *email* and also by *web* for those cases where The email one requires additional steps, so this is unnecessary work confusing submitters. I submit dozens or hundreds of patches every release cycle. That's the only subsystem which is odd to use. > the emails get screwed up by ones company mail server. That's why the > web interface exists - to give people *flexibility*. No, they are not. None of my emails are screwed by my company system. > > The fact is, the web interface is merely a front end interface that > generates an email and submits it in the usual way by email - an > email that you can perfectly well generate that is *very* close to > the standard email that git format-patch generates. > > The *only* difference is that the patch system wants a KernelVersion: > tag in the email _somewhere_ and it doesn't matter where it appears. > Git even has support to do this. > > git format-patch --add-header="KernelVersion: $foo" > > Why does it want the kernel version? Because when we were running 2.4 > and 2.5 kernel versions in parallel, it was important to know which > tree the patch was being submitted for. It has continued to be required Which is absolutely ridiculous now. Expecting submitters to adhere to some rule for 20 year old kernel is not reasonable. > because it means when there's problems applying a patch, it gives me > the additional information about the base used for the patch (and it > keeps on being useful to have.) > >> That's the response: >> ------------- >> Your patch has not been logged because: >> >> Error: Please supply a summary subject line briefly describing >> your patch. >> >> >> Error: Please supply a "KernelVersion: " tag after "PATCH FOLLOWS" or >> "---". >> >> Error: the patch you are submitting has one or more missing or incorrect >> Signed-off-by lines: >> >> - author signoff is missing. ^^^ here you have additional SoB expectation. >> >> Please see the file Documentation/SubmittingPatches, section 11 >> for details on signing off patches. > > Lots of people use it without a problem. I've just run the parser > through its offline tests, and it parses email content correctly. > I've no idea what you're doing wrong, but it looks like something > pretty serious if it didn't parse the subject line. > > Rather than getting stressed about it, why don't you send me an email > the first time something goes wrong so I can investigate, turn on > debugging to capture the problem email? I don't know any person who enjoyed working with your patch workflow. >From few people I talked, it was always "now I have to learn this weird system" or "I need to get through this process which is different than everything in the kernel". Plus you entirely ignored poor usability of this system which: 1. Allows submitting patches only 1-by-1, so 19 useless steps in my case. 2. Accepts the first/second/all patches without problem encouraging me to submit the rest... and then tells me via email they were wrong and could not be accepted. This is the poorest user-experience one can imagine. If you put effort into some web form, make it at least helpful so reject the patch if it does not match your expectations. Best regards, Krzysztof